Add methods to sort license JSON and license JSON TOC#430
Merged
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
Should I add sort for LicenseJsonTOC and ExceptionJsonTOC in this PR too? Both are small. |
Collaborator
|
@bact seems to me that deterministic ordering of all elements may be important. |
goneall
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get more stable JSON output
Note
For LicenseListPublisher, to sort
crossRefin the JSON output, apply spdx/LicenseListPublisher#244 after the change is this PR is released.