Model class initialization

[davaya]

A question about code style. As an example the Agent class is:

@dataclass_with_properties
class Agent(Element):
    def __init__(
        self,
        spdx_id: str,
        creation_info: Optional[CreationInfo] = None,
        name: Optional[str] = None,
        summary: Optional[str] = None,
        description: Optional[str] = None,
        comment: Optional[str] = None,
        verified_using: List[IntegrityMethod] = None,
        external_reference: List[ExternalReference] = None,
        external_identifier: List[ExternalIdentifier] = None,
        extension: Optional[str] = None,
    ):
        verified_using = [] if verified_using is None else verified_using
        external_reference = [] if external_reference is None else external_reference
        external_identifier = [] if external_identifier is None else external_identifier
        check_types_and_set_values(self, locals())

• Is there a reason verified_using, external_reference and external_identifier cannot be initialized as None?
• If they do need to be empty arrays instead of None, can't that be done by making the argument default = []?
• Is there a reason the core dataclasses are at the top level instead of in a core directory?

[armintaenzertng]

• We ensured that list-valued properties are always lists so we don't have to do the check for None every time we want to iterate over them (iterating over an empty list is completely fine and just does nothing as one would expect when the property is not set).
• Mutable types like lists can't be used as default arguments as they would be shared between different instances of the class. See for example here.
• The design decision to have core classes on top level was made because core is not really a profile on its own and so that users don't have to search for the most vital entry point into the model.

[harshkasat]

@armintaenzertng Hey there! I have a few questions:

• Is this issue currently in the working phase?
• If we make them None or Optional, will it affect serialization? If yes, how can we resolve this issue?

[armintaenzertng]

Hi @harshkasat. The way I understand it, this issue a question, not a direct call for work. As I answered the question in my previous post and there has been no activity for half a year, I think this issue can be closed.
Please tell me if you disagree, and we can reopen it again.