refactor: replace local overlay package with speakeasy-api/openapi/overlay#24
Merged
TristanSpeakEasy merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Refactors the project to stop using the local overlay implementation and instead rely on the upstream github.com/speakeasy-api/openapi/overlay, while updating overlay defaults and Go/dependencies.
Changes:
- Replace local
pkg/overlayimplementation (and its tests/testdata) with the upstream overlay module. - Bump web overlay defaults from spec
1.0.0to1.1.0. - Update Go version and module dependencies; rebuild WASM against the new overlay dependency.
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/src/defaults.ts | Updates default overlay spec version strings to 1.1.0. |
| pkg/overlay/validate.go | Removes local overlay validation logic (file deleted). |
| pkg/overlay/schema.go | Removes local overlay schema types and YAML serialization (file deleted). |
| pkg/overlay/parse.go | Removes local overlay parse/format helpers (file deleted). |
| pkg/overlay/parents.go | Removes local YAML parent indexing utility (file deleted). |
| pkg/overlay/apply.go | Removes local overlay apply/merge implementation (file deleted). |
| pkg/overlay/compare.go | Removes local overlay compare/diff implementation (file deleted). |
| pkg/overlay/apply_test.go | Removes overlay apply snapshot test (file deleted). |
| pkg/overlay/compare_test.go | Removes overlay compare + roundtrip test (file deleted). |
| pkg/overlay/parse_test.go | Removes overlay parse/format test (file deleted). |
| pkg/overlay/testdata/* | Deletes overlay/openapi fixtures used by removed snapshot tests. |
| go.mod | Updates Go version and pulls in github.com/speakeasy-api/openapi dependency. |
| cmd/wasm/functions.go | Switches WASM code to import and use the upstream overlay package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
disintegrator
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/overlay/package (~1,700 lines) in favor of the upstreamgithub.com/speakeasy-api/openapi/overlaypackage1.0.0to1.1.0in web defaultsMotivation
The overlay logic was duplicated between this repo and the
openapimodule. Consolidating on the upstream package reduces maintenance burden and keeps overlay behavior consistent across projects.Test plan