Do not set data-dfn-for on top level IDL objects#3768
Merged
marcoscaceres merged 3 commits intospeced:developfrom Sep 7, 2021
Merged
Do not set data-dfn-for on top level IDL objects#3768marcoscaceres merged 3 commits intospeced:developfrom
marcoscaceres merged 3 commits intospeced:developfrom
Conversation
Contributor
|
@dontcallmedom, not sure how much you want to spend on this... I can try to fix it later this week. Few notes/todo:
|
Member
Author
|
I'm supportive of DRYing and testing the code, but at the moment, this bug means quite a few IDL names from the permission API creates linking errors, so I would prefer if we could hot fix this and worry about the rest separately. |
Contributor
|
Ok, no problem. @dontcallmedom, can you: |
Member
Author
|
linted |
Contributor
|
I'll update merge it once it's green, but will leave the bug open so I remember to add the tests, etc. |
marcoscaceres
approved these changes
Sep 7, 2021
Contributor
|
Released respec@26.13.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.