test(webidl): regression test for top-level IDL data-dfn-for fix#5178
Open
marcoscaceres wants to merge 3 commits intomainfrom
Open
test(webidl): regression test for top-level IDL data-dfn-for fix#5178marcoscaceres wants to merge 3 commits intomainfrom
marcoscaceres wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a WebIDL regression test to ensure top-level IDL dictionaries/enums inside a data-dfn-for section don’t end up associated with that “for” context (regression coverage for #3764, fixed by #3768).
Changes:
- Extends the WebIDL HTML fixture with a
data-dfn-forsection containing a top-leveldictionaryandenum. - Adds a Jasmine test asserting those generated definitions don’t carry a
data-dfn-forvalue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/spec/core/webidl.html | Adds a new fixture section containing top-level dictionary/enum inside a data-dfn-for container. |
| tests/spec/core/webidl-spec.js | Adds a regression test checking data-dfn-for isn’t applied to those top-level IDL entities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test verifying that dictionaries and enums defined inside a data-dfn-for section do not inherit that attribute. Regression test for #3764, fixed by PR #3768.