Skip to content

Update to v6.8.03 - #1189

Merged
grantfitzsimmons merged 32 commits into
masterfrom
v6.8.03
Mar 6, 2023
Merged

Update to v6.8.03#1189
grantfitzsimmons merged 32 commits into
masterfrom
v6.8.03

Conversation

@melton-jason

@melton-jason melton-jason commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Testing

Most recent build

BigDecimal :

  • Enter any value into any BigDecimal field
  • Test Validation (enter 0, negative numbers, and invalid characters a[]{....
  • Run a Query on BigDecimal fields and see if the results match display on forms
  • Create a Report/Label using any BigDecimal fields (and test formatBigDecimal and truncateBigDecimal Scriptlets)
  • Export BigDecimal fields and verify the results match Form/Query Results display
  • Do additional light testing with Latitude and Longitude fields in Locality

Carry Forward:

  • Test Carry Forward on the following tables:
    • AccessionCitation
    • CollectionObjectCitation
    • DNASequencingRunCitaiton
    • TaxonCitation
  • Ensure all expected values are stored correctly in the database and display on forms
  • More specifically, check if the information of the base table for each Citation is carry forwarded correctly

BusinessRules:

  • Make sure an Agent of type Other/Group can be given addresses, and that this address can be queried on

Plugins

  • Ensure the WorldWind plugin button is not visible when using MacOS

Changes:

BigDecimals:

  • Strip down BigDecimals on form displays
  • Improve validation for BigDecimals on forms (accept negative numbers and zero)
  • Strip down BigDecimals in QueryResults
  • DO NOT strip BigDecimals in Lables/Report (and add new truncateBigDecmials Scriptlet)
  • Strip BigDecimals in Data Exports

Carry Forward:
Added support for the following tables:

  • AccessionCitation
  • CollectionObjectCitation
  • DNASequencingRunCitation
  • TaxonCitation

Business Rules:

  • Allow Agents of type Other and Group to have addresses

Plugins:

  • Disable the WorldWind plugin on MacOS

maxpatiiuk and others added 22 commits December 16, 2022 15:42
Forgot to remove it after doing debugging
See #1181
Briefly tested in QueryBuilder, yet this may affect Reports, Labels, and
other exports.
Fixes # 1179

Adds a clone() implementation to the following Citation Tables:
- AccessionCitation
- CollectionObjectCitation
- DNASequencingRunCitation
- TaxonCitation

A basic implementation was made for each: these each need to be
addressed further to iron out potential problems and solidify which
fields should and should not be cloned.
Adds an isModified flag to the query (default is true).
If not modified, the returned results will be straight from the
Database.

With this change, Reports and Exports will tell the query to not be
modified
Formats a BigDecimal to how it would appear in Query Builder Results and
on Forms

Should hopefully provide enough flexibility for working with
BigDecimals' alongside the formatBigDecimal Scriplet in Reports and Labels

(NOTE: This and other Scriptlets return a String becuase those are not
formatted [have a 'pattern'] by IReport.
IReport formats all numeric values by default to only have two places after
the decimal unless specified in the JRXML).
If the value is the equivalent of an integer or zero,format it to #.0
Affects Forms, QueryBuilder Results, and Data Exports
This maintains consistency between Specify 6.8.01, where all decimal
fields were formatted to one decimal place
@grantfitzsimmons

Copy link
Copy Markdown
Member
  • I can enter a wide variety of decimal values in BigDecimal fields and they are presented correctly in the forms and in query results.
  • Queries build correctly, display correctly, and can be exported to XLS and preserve the format established in Specify
  • 0, -0, -123.1245, 123.142451123, etc. all display and function correclty
  • Issue with negative decimals and zero have been resolved.

DataExporter:
When building and exporting a schema mapping (using two BigDecimal fields) with the DataExporter tool, it still presents the data with 9 decimal places:
export.csv

image

@melton-jason
melton-jason marked this pull request as ready for review January 11, 2023 18:05
@melton-jason

Copy link
Copy Markdown
Contributor Author

DataExporter:
When building and exporting a schema mapping (using two BigDecimal fields) with the DataExporter tool, it still presents the data with 9 decimal places:

It appears the changes in 5765d96 only modified the DataExport preview within the actual Specify 6 software. Fixed in 1913fc8.
test_export

If there are any other exports that need to be modified, please let me know so I can get them fixed.

@grantfitzsimmons

Copy link
Copy Markdown
Member

Can verify the fix 1913fc8 works successfully on my system.

@grantfitzsimmons grantfitzsimmons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@grantfitzsimmons

Copy link
Copy Markdown
Member

@melton-jason How are the other export changes going?

@grantfitzsimmons
grantfitzsimmons merged commit 945d28f into master Mar 6, 2023
@grantfitzsimmons
grantfitzsimmons deleted the v6.8.03 branch March 6, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants