Update to v6.8.03 - #1189
Merged
Merged
Conversation
Forgot to remove it after doing debugging
Merge issue-1181 to 6.8.03
Merge issue-1180 to 6.8.03
See #1181 Briefly tested in QueryBuilder, yet this may affect Reports, Labels, and other exports.
Fixes # 1179 Adds a clone() implementation to the following Citation Tables: - AccessionCitation - CollectionObjectCitation - DNASequencingRunCitation - TaxonCitation A basic implementation was made for each: these each need to be addressed further to iron out potential problems and solidify which fields should and should not be cloned.
Adds an isModified flag to the query (default is true). If not modified, the returned results will be straight from the Database. With this change, Reports and Exports will tell the query to not be modified
Formats a BigDecimal to how it would appear in Query Builder Results and on Forms Should hopefully provide enough flexibility for working with BigDecimals' alongside the formatBigDecimal Scriplet in Reports and Labels (NOTE: This and other Scriptlets return a String becuase those are not formatted [have a 'pattern'] by IReport. IReport formats all numeric values by default to only have two places after the decimal unless specified in the JRXML).
If the value is the equivalent of an integer or zero,format it to #.0 Affects Forms, QueryBuilder Results, and Data Exports This maintains consistency between Specify 6.8.01, where all decimal fields were formatted to one decimal place
Member
DataExporter: |
melton-jason
marked this pull request as ready for review
January 11, 2023 18:05
Contributor
Author
It appears the changes in 5765d96 only modified the DataExport preview within the actual Specify 6 software. Fixed in 1913fc8. If there are any other exports that need to be modified, please let me know so I can get them fixed. |
Member
|
Can verify the fix 1913fc8 works successfully on my system. |
This was referenced Jan 12, 2023
Member
|
@melton-jason How are the other export changes going? |
These changes are not compatible with Specify 7, so they will be removed in favor of a future implementation in Specify 7
grantfitzsimmons
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Testing
Most recent build
BigDecimal :
0, negative numbers, and invalid charactersa[]{....formatBigDecimalandtruncateBigDecimalScriptlets)LocalityCarry Forward:
BusinessRules:
Plugins
Changes:
BigDecimals:
truncateBigDecmialsScriptlet)Carry Forward:
Added support for the following tables:
Business Rules:
Plugins: