Fix downloading single attachment with "Download All" on Firefox#6619
Merged
Fix downloading single attachment with "Download All" on Firefox#6619
Conversation
Triggered by 3e86e27 on branch refs/heads/issue-6536
CarolineDenis
approved these changes
Jun 11, 2025
pashiav
approved these changes
Jun 11, 2025
Contributor
pashiav
left a comment
pashiav
left a comment
There was a problem hiding this comment.
- Make sure the attachment was downloaded (it shouldn't be in a zip file)
- Make sure it works on Chrome too
Looks good - working on both Firefox and Chrome!
Screen.Recording.2025-06-11.at.1.12.44.PM.mov
Collaborator
|
Couldn't recreate the issue on production personally so I can't test this PR; I'm on Firefox version 139.0.4 which is one ahead of the version reported in the issue. Noting this in case others have issues recreating the issue. |
bhumikaguptaa
approved these changes
Jul 1, 2025
Collaborator
bhumikaguptaa
left a comment
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Make sure the attachment was downloaded (it shouldn't be in a zip file)
- Make sure it works on Chrome too
Looks good!
Triggered by fefe2d3 on branch refs/heads/issue-6536
github-project-automation
bot
moved this from 📋Back Log
to ✅Done
in General Tester Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6536
It appears Firefox is stricter about downloading files from iframes than Chrome.
No other file downloads in Specify should be affected by this bug, since this was a unique case of a file being downloaded from a URL rather than being created by the front end (aka exports like CSVs).
Checklist
self-explanatory (or properly documented)
Testing instructions
NOTE: This should be tested on the test panel. I don't believe the issue can be recreated locally, but you can make sure you are testing it correctly by recreating the original issue.