Skip to content

Fix downloading single attachment with "Download All" on Firefox #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alesan99 merged 4 commits into from
Sep 29, 2025
Merged

Fix downloading single attachment with "Download All" on Firefox #6619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e86e27
Use workaround for downloading attachments
alesan99 Jun 11, 2025
718443a
Lint code with ESLint and Prettier
alesan99 Jun 11, 2025
fefe2d3
Merge branch 'main' into issue-6536
alesan99 Sep 29, 2025
271e20f
Lint code with ESLint and Prettier
alesan99 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specifyweb/frontend/js_src/lib/components/Attachments/__tests__/UploadAttachment.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { testAttachment } from './utils';
requireContext();

async function uploadFileMock(): Promise<SpecifyResource<Attachment>> {
return deserializeResource(testAttachment) ;
return deserializeResource(testAttachment);
}

beforeEach(() => {
Expand Down
12 changes: 7 additions & 5 deletions specifyweb/frontend/js_src/lib/components/Attachments/attachments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,13 @@ export function downloadAttachment(
const fileName = cleanAttachmentDownloadName(
attachment.origFilename ?? attachment.attachmentLocation
);
downloadFile(
fileName,
`/attachment_gw/proxy/${new URL(url).search}`,
true
);
// Cannot use downloadFile because of iframe restrictions
const element = document.createElement('a');
element.href = `/attachment_gw/proxy/${new URL(url).search}`;
element.download = fileName;
document.body.append(element);
element.click();
element.remove();
}
});
}
Expand Down
8 changes: 2 additions & 6 deletions specifyweb/frontend/js_src/lib/components/Molecules/FilePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ export function FilePicker({
*/
export const downloadFile = async (
fileName: string,
data: Blob | string,
isUrl?: boolean
data: Blob | string
): Promise<void> =>
new Promise((resolve) => {
let fileDownloaded = false;
Expand All @@ -148,10 +147,7 @@ export const downloadFile = async (
if (iframe.contentWindow === null || fileDownloaded) return;
let dataUrl: string | undefined;
const element = iframe.contentWindow.document.createElement('a');
if (isUrl === true) {
element.setAttribute('href', data as string);
element.setAttribute('download', fileName);
} else if (typeof data === 'string') {
if (typeof data === 'string') {
element.setAttribute(
'href',
`data:text/plain;charset=utf-8,${encodeURIComponent(data)}`
Expand Down