Skip to content

[test]: export with delimiter and column order - #8389

Merged
CarolineDenis merged 6 commits into
mainfrom
issue-8385
Aug 3, 2026
Merged

[test]: export with delimiter and column order#8389
CarolineDenis merged 6 commits into
mainfrom
issue-8385

Conversation

@rijulpoudel

@rijulpoudel rijulpoudel commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Fixes #8385

Summary by CodeRabbit

  • Tests
    • Added coverage verifying exported datasets preserve visible column order, blank cells, and configured delimiters.
    • Added coverage for CSV and tab-delimited TSV exports, including filenames and serialized content.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

Warning

One or more dependencies are approaching or past End-of-Life.
Please plan upgrades accordingly.

STATUS=WARNING
NODE_VERSION=20
NODE_CYCLE=20
EOL_DATE=2026-04-30
DAYS_REMAINING=-95

--- Node.js ---
Version: 20
EOL: 2026-04-30
Status: WARNING

STATUS=OK
PYTHON_VERSION=3.12
PYTHON_CYCLE=3.12
EOL_DATE=2028-10-31
DAYS_REMAINING=820

--- Python ---
Version: 3.12
EOL: 2028-10-31
Status: OK

STATUS=WARNING
DJANGO_VERSION=4.2
DJANGO_CYCLE=4.2
EOL_DATE=2026-04-07
DAYS_REMAINING=-118

--- Django ---
Version: 4.2
EOL: 2026-04-07
Status: WARNING


@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 47acddbd-50eb-483f-a690-52a624836171

📥 Commits

Reviewing files that changed from the base of the PR and between 2c4d87b and 13e0bcd.

📒 Files selected for processing (6)
  • specifyweb/frontend/js_src/lib/components/AttachmentsBulkImport/Import.tsx
  • specifyweb/frontend/js_src/lib/components/AttachmentsBulkImport/MatchingModeDialog.tsx
  • specifyweb/frontend/js_src/lib/components/AttachmentsBulkImport/ViewAttachmentFiles.tsx
  • specifyweb/frontend/js_src/lib/components/AttachmentsBulkImport/__tests__/utils.test.ts
  • specifyweb/frontend/js_src/lib/components/AttachmentsBulkImport/useEagerDataset.ts
  • specifyweb/frontend/js_src/lib/components/AttachmentsBulkImport/utils.ts

📝 Walkthrough

Walkthrough

Added tests for CSV and TSV dataset serialization and WbToolkit export behavior. The changes also reformat bulk-import code and tests without changing behavior.

Changes

Export tests and bulk-import formatting

Layer / File(s) Summary
Export coverage
specifyweb/frontend/js_src/lib/components/WorkBench/__tests__/helpers.test.ts, specifyweb/frontend/js_src/lib/components/WbToolkit/__tests__/Export.test.tsx
Tests verify CSV and TSV output, filenames, delimiters, headers, rows, trailing newlines, visible column ordering, and preserved blank cells.
Bulk-import formatting
specifyweb/frontend/js_src/lib/components/AttachmentsBulkImport/*
Reformats component logic, utility code, and test fixtures without changing behavior or values.

Suggested reviewers: carolinedenis, emenslin

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes unrelated formatting-only changes across AttachmentsBulkImport files that are outside issue #8385. Remove the unrelated AttachmentsBulkImport formatting changes, or separate them into a dedicated pull request.
Testing Instructions ⚠️ Warning The PR description contains only “Fixes #8385” and omits the template’s Testing instructions section, despite changes affecting WbToolkit and WorkBench export tests. Add clear verification steps: run the two targeted Jest files from specifyweb/frontend/js_src and state the expected column-order, blank-cell, delimiter, filename, and serialization results.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes tests for export delimiter handling and column order, which are the primary changes.
Linked Issues check ✅ Passed The PR adds WorkBench export tests for delimiter handling, column ordering, filenames, and serialized content, satisfying issue #8385.
Automatic Tests ✅ Passed The PR adds Jest tests for WbToolkit export ordering, blank cells, and delimiter use, plus downloadDataSet CSV and TSV serialization tests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8385

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rijulpoudel

Copy link
Copy Markdown
Collaborator Author

@CodeRabbit Full Review

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@CarolineDenis CarolineDenis added this to the 7.12.1 milestone Aug 3, 2026
@CarolineDenis
CarolineDenis merged commit 42bdadf into main Aug 3, 2026
24 checks passed
@CarolineDenis
CarolineDenis deleted the issue-8385 branch August 3, 2026 07:23
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

[test]: Export a WorkBench data set

2 participants