Skip to content

bump jquery and @types/jquery - #8480

Merged
CarolineDenis merged 2 commits into
mainfrom
issue-8479
Sep 2, 2026
Merged

bump jquery and @types/jquery#8480
CarolineDenis merged 2 commits into
mainfrom
issue-8479

Conversation

@CarolineDenis

@CarolineDenis CarolineDenis commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes #8579

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR
  • Add migration function to
    def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

General testing:

  • Test the main UI flows: navigation, forms, buttons, tabs, dialogs/modals, and dropdowns.
  • Test record creation/editing, saving, searching, queries, and tables/grids.
  • Check dynamic interactions such as show/hide fields, autocomplete, notifications, and validation.
  • Watch for visual/layout regressions.
  • Test in the main supported browsers.

Summary by CodeRabbit

  • Chores
    • Updated the application’s jQuery runtime to version 4.
    • Updated jQuery development type definitions to the corresponding version.

@CarolineDenis CarolineDenis added this to the 7.12.2 milestone Sep 1, 2026
@github-project-automation github-project-automation Bot moved this to 📋Back Log in General Tester Board Sep 1, 2026
@CarolineDenis
CarolineDenis requested a review from a team September 1, 2026 12:29
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 423b9c55-b6c1-4697-ac9b-d8832479bb39

📥 Commits

Reviewing files that changed from the base of the PR and between a176716 and 1d2a06d.

⛔ Files ignored due to path filters (1)
  • specifyweb/frontend/js_src/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • specifyweb/frontend/js_src/package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates the jQuery runtime dependency from ~1.12.0 to ~4.0.0 and the @types/jquery development dependency from ~3.5.4 to ~4.0.1.

Changes

jQuery dependency updates

Layer / File(s) Summary
Update jQuery dependency versions
specifyweb/frontend/js_src/package.json
The runtime jquery dependency changes to ~4.0.0. The @types/jquery development dependency changes to ~4.0.1.

Suggested reviewers: g1rly-c0d3r

Merge Risk: ⚪ Minimal · up to 1d2a0

This PR updates jQuery from ~1.12.0 to ~4.0.0 and @types/jquery from ~3.5.4 to ~4.0.1; the affected integration uses supported APIs, with no concrete current-head correctness, security, availability, or deployment risk identified. It is merge-ready after normal checks, with no actionable merge-blocking risk remaining.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Testing Instructions ⚠️ Warning The testing instructions in the PR description are clear but do not accurately cover the affected components for a jQuery version bump from 1.12.0 to 4.0.0. Evidence: - Git diff confirms the PR ch… The PR should include additional, specific testing instructions that address: 1. Test Backbone model and collection operations, particularly event triggers (on, off, trigger) 2. Verify all business rules engine functionality works correctly…
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main changes: upgrading jQuery and its TypeScript definitions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Automatic Tests ✅ Passed PASS. The PR changes only jQuery dependency metadata and the lockfile. No application or test code changes are required for this dependency-only update. Existing Jest tests exercise the affected Backb…
Full details: Automatic Tests

Explanation

PASS. The PR changes only jQuery dependency metadata and the lockfile. No application or test code changes are required for this dependency-only update. Existing Jest tests exercise the affected Backbone/DataModel path, and the frontend CI job runs typecheck and unit tests when frontend files change. The PR description also provides manual UI testing instructions.

Full details: Testing Instructions

Explanation

The testing instructions in the PR description are clear but do not accurately cover the affected components for a jQuery version bump from 1.12.0 to 4.0.0. Evidence: - Git diff confirms the PR changes jQuery from ~1.12.0 to ~4.0.0 and @types/jquery from ~3.5.4 to ~4.0.1 - Code analysis shows jQuery is used in two critical areas: 1. backbone.ts: Imports jQuery and assigns it to Backbone.$ for Backbone.js integration 2. testBusinessRules.js: Uses jQuery.Deferred() for async testing - This is a major version bump spanning approximately 8 years (February 2016 to January 2024) with significant API changes Gaps in provided testing instructions: The PR provides five generic testing areas: 1. Main UI flows (navigation, forms, buttons, tabs, dialogs/modals, dropdowns) 2. Record operations (creation, editing, saving, searching, queries, tables) 3. Dynamic interactions (show/hide, autocomplete, notifications, validation) 4. Visual/layout regressions 5. Browser compatibility testing What is missing: - Specific testing of Backbone.js model/collection operations, which depend on jQuery for event handling and DOM operations - Verification that Backbone's jQuery integration functions correctly with jQuery 4.0 - Business rules engine testing (which uses jQuery Deferred) - Guidance for testing event triggers and listeners, which may behave differently between jQuery 1.12 and 4.0 - Alert that jQuery 4.0 dropped support for IE < 10 (if applicable to supported browsers) The instructions cover general application workflows but lack specific guidance targeted to the jQuery version upgrade and its affected components (Backbone integration, event handling, Deferred promises).

Resolution

The PR should include additional, specific testing instructions that address: 1. Test Backbone model and collection operations, particularly event triggers (on, off, trigger) 2. Verify all business rules engine functionality works correctly 3. Test any Backbone-managed event listeners and callbacks 4. Confirm jQuery AJAX behavior (if used indirectly through Backbone) works as expected with jQuery 4.0 5. Document any known compatibility differences between jQuery 1.12.0 and 4.0.0 that testers should watch for Example addition to testing instructions: "Additionally, test Backbone-dependent features including data model operations, event handling, and the business rules engine, as jQuery 4.0 introduces significant changes from the 1.12.0 branch."

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8479

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@g1rly-c0d3r g1rly-c0d3r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Test the main UI flows: navigation, forms, buttons, tabs, dialogs/modals, and dropdowns.
  • Test record creation/editing, saving, searching, queries, and tables/grids.
  • Check dynamic interactions such as show/hide fields, autocomplete, notifications, and validation.
  • Watch for visual/layout regressions.
  • Test in the main supported browsers.

Looks good! I tested on both Firefox and Chrome, neither had any issues I could find.

@JDAM2k4 JDAM2k4 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Test the main UI flows: navigation, forms, buttons, tabs, dialogs/modals, and dropdowns.
  • Test record creation/editing, saving, searching, queries, and tables/grids.
  • Check dynamic interactions such as show/hide fields, autocomplete, notifications, and validation.
  • Watch for visual/layout regressions.
  • Test in the main supported browsers.

I tested this in both Chrome and Edge and everything seemed to look alright.

@rijulpoudel rijulpoudel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Test the main UI flows: navigation, forms, buttons, tabs, dialogs/modals, and dropdowns.
  • Test record creation/editing, saving, searching, queries, and tables/grids.
  • Check dynamic interactions such as show/hide fields, autocomplete, notifications, and validation.
  • Watch for visual/layout regressions.
  • Test in the main supported browsers.

I tested this on Chrome and everything seems to pass fine.

@rijulpoudel

Copy link
Copy Markdown
Member

@CodeRabbit Full review

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@CarolineDenis
CarolineDenis merged commit c5e9104 into main Sep 2, 2026
20 checks passed
@CarolineDenis
CarolineDenis deleted the issue-8479 branch September 2, 2026 10:39
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Sep 2, 2026
@CarolineDenis CarolineDenis linked an issue Sep 2, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

bump jquery and @types/jquery in /specifyweb/frontend/js_src

4 participants