Skip to content

Conversation

@lucaspar
Copy link
Member

@lucaspar lucaspar commented Dec 9, 2025

Fixes some cases when it was possible to have a capture without any files associated to it.

Linked to tickets SFDS-289 and SFDS-278.

  • Empty file trees during capture creation raise a ValueError, which returns a 400 error to client.
  • justfile "args" passed correctly, allowing e.g. just test-py -k my_test_case.

@lucaspar lucaspar self-assigned this Dec 9, 2025
@lucaspar lucaspar added bug Something isn't working gateway Gateway component labels Dec 9, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 9, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  gateway/sds_gateway/api_methods/views/capture_endpoints.py  32% smaller
  gateway/sds_gateway/api_methods/tests/test_opensearch.py  16% smaller
  gateway/sds_gateway/api_methods/tests/test_capture_endpoints.py  9% smaller
  gateway/justfile Unsupported file format

@lucaspar lucaspar marked this pull request as ready for review December 9, 2025 20:51
@lucaspar lucaspar requested review from Copilot and klpoland December 9, 2025 20:51
@lucaspar lucaspar changed the title gwy: fixed potentially unbound var Reviewing capture creation process Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucaspar lucaspar force-pushed the lp/gwy-capture-creation-checks branch from daaf3e3 to dbc7fd3 Compare December 12, 2025 17:52
@lucaspar lucaspar merged commit dbc7fd3 into master Dec 12, 2025
@lucaspar lucaspar deleted the lp/gwy-capture-creation-checks branch December 12, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gateway Gateway component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants