Cursor/continuous integration failures 477d#311
Merged
lucaspar merged 3 commits intoJun 30, 2026
Conversation
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Refactor and typing/test adjustments only; download and upload logic paths are unchanged aside from clearer variable scoping.
Overview
Small SDK cleanup aimed at continuous integration failures, with no intended behavior change for downloads or uploads.
In
Client._download_files,total_bytes_totalis now set only inside the list vs paginator branches (byte-level progress when the file source is a list;Noneand the fallback path for aPaginator). The completion log still uses the same variables after both branches.GatewayClient.upload_new_filewidens thefile_ptrtype toBinaryIO | _ProgressFileReaderso type checkers accept wrapping the file handle when aprogress_callbackis used.test_download_fails_for_invalid_filesdropscapsysand stderr checks for "simulating download", keeping assertions onResultsuccess/failure and error payloads.Reviewed by Cursor Bugbot for commit b7ce61c. Configure here.