Skip to content

Cursor/continuous integration failures 477d#311

Merged
lucaspar merged 3 commits into
lp/uploads-monitoringfrom
cursor/continuous-integration-failures-477d
Jun 30, 2026
Merged

Cursor/continuous integration failures 477d#311
lucaspar merged 3 commits into
lp/uploads-monitoringfrom
cursor/continuous-integration-failures-477d

Conversation

@lucaspar

@lucaspar lucaspar commented Jun 30, 2026

Copy link
Copy Markdown
Member

Note

Low Risk
Refactor and typing/test adjustments only; download and upload logic paths are unchanged aside from clearer variable scoping.

Overview
Small SDK cleanup aimed at continuous integration failures, with no intended behavior change for downloads or uploads.

In Client._download_files, total_bytes_total is now set only inside the list vs paginator branches (byte-level progress when the file source is a list; None and the fallback path for a Paginator). The completion log still uses the same variables after both branches.

GatewayClient.upload_new_file widens the file_ptr type to BinaryIO | _ProgressFileReader so type checkers accept wrapping the file handle when a progress_callback is used.

test_download_fails_for_invalid_files drops capsys and stderr checks for "simulating download", keeping assertions on Result success/failure and error payloads.

Reviewed by Cursor Bugbot for commit b7ce61c. Configure here.

cursoragent and others added 3 commits June 30, 2026 18:09
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
@semanticdiff-com

semanticdiff-com Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  sdk/src/spectrumx/client.py  6% smaller
  sdk/src/spectrumx/gateway.py  5% smaller
  sdk/tests/test_client.py  0% smaller

@lucaspar lucaspar merged commit b4eeb80 into lp/uploads-monitoring Jun 30, 2026
1 check passed
@lucaspar lucaspar deleted the cursor/continuous-integration-failures-477d branch June 30, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants