PR to address the comments on the ESC50 recipe#2070
Merged
mravanelli merged 28 commits intospeechbrain:developfrom Jul 16, 2023
Merged
PR to address the comments on the ESC50 recipe#2070mravanelli merged 28 commits intospeechbrain:developfrom
mravanelli merged 28 commits intospeechbrain:developfrom
Conversation
Collaborator
|
Excellent work! I tested both the training recipes and HF interfaces and everything works. I only have the following comments:
|
mravanelli
approved these changes
Jul 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to address the comments of Mirco in #2066
Here are the original comments and the progress:
/ESC50/classification/:---> note: this repository is called speechbrain/cnn14-esc50 now.
/recipes/ESC50/interpret:When introducing PIQ, please add a reference to our paper. Additionally, at the end, you can include a section on citing PIQ with the necessary BibTeX information. [done]
Create a new interface and a corresponding HF repository for the PIQ Model. In this case, the input should be a signal, and the output should be the audio for interpretation, correct? [done]
For this interface, please upload one or two example files (maybe one positive and one negative example) and briefly explain the outcomes in the text. [done]
In
/ESC50/interpret/train_piq.py, please add missing docstrings. All functions should have at least a short description. [done]The YAML files should use the pretrained model form the speechbrain HF repository (remember to make it public). Currently, it is using
fpaissan/conv2d_us8korcemsubakan/cnn14-esc50/[done].It would be helpful to write a short tutorial on interpretability with a special focus on PIQ [I think this might stay out of scope of this PR].