Skip to content

Enhance weekly financial reports workflow with group name validation #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anatolyshipitz merged 3 commits into from
Jun 11, 2025
Merged

Enhance weekly financial reports workflow with group name validation #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de66e3b
Add GroupNameEnum and update TargetUnit types (#57)
anatolyshipitz Jun 10, 2025
b3081df
Enhance weekly financial reports workflow with group name validation
anatolyshipitz Jun 10, 2025
cc32ff3
Merge branch 'main' into feature/groupName-validation
anatolyshipitz Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { describe, expect, it, vi } from 'vitest';

import { GroupNameEnum } from '../../configs/weeklyFinancialReport';
import { weeklyFinancialReportsWorkflow } from './weeklyFinancialReports.workflow';

vi.mock('@temporalio/workflow', () => ({
Expand All @@ -15,7 +16,9 @@ vi.mock('@temporalio/workflow', () => ({

describe('weeklyFinancialReportsWorkflow', () => {
it('returns the fileLink from getTargetUnits', async () => {
const result = await weeklyFinancialReportsWorkflow();
const result = await weeklyFinancialReportsWorkflow(
GroupNameEnum.ED_REPORT,
);

expect(result).toBe('sub-dir/mocked-link.json');
});
Expand Down
13 changes: 12 additions & 1 deletion workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,25 @@
import { proxyActivities } from '@temporalio/workflow';

import type * as activities from '../../activities/weeklyFinancialReports';
import { AppError } from '../../common/errors';
import { GroupName } from '../../common/types';
import { GroupNameEnum } from '../../configs/weeklyFinancialReport';

const { getTargetUnits, fetchFinancialAppData } = proxyActivities<
typeof activities
>({
startToCloseTimeout: '10 minutes',
});

export async function weeklyFinancialReportsWorkflow(): Promise<string> {
export async function weeklyFinancialReportsWorkflow(
groupName: GroupName,
): Promise<string> {
Comment thread
anatolyshipitz marked this conversation as resolved.
if (!(Object.values(GroupNameEnum) as GroupName[]).includes(groupName)) {
throw new AppError(
`Invalid groupName paramter: ${groupName}. Allowed values: "${Object.values(GroupNameEnum).join('", "')}"`,
'weeklyFinancialReportsWorkflow',
);
}
const targetUnits = await getTargetUnits();
const finData = await fetchFinancialAppData(targetUnits.fileLink);

Expand Down