Skip to content

Enhance weekly financial reports workflow to include Slack reporting #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anatolyshipitz merged 11 commits into from
Jul 8, 2025
Merged

Enhance weekly financial reports workflow to include Slack reporting #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e377e71
Add currency formatting and rate retrieval functions with unit tests
anatolyshipitz Jun 11, 2025
bf28801
Sort rate history dates in chronological order in getRateByDate function
anatolyshipitz Jun 11, 2025
35e6dd3
Add Weekly Financial Report functionality with repository and tests
anatolyshipitz Jun 11, 2025
311062c
Add sendReportToSlack activity
anatolyshipitz Jun 11, 2025
2a3d6b5
Merge branch 'main' into feature/add-WeeklyFinancialReportRepository
killev Jun 12, 2025
50f6dd3
Merge branch 'feature/add-WeeklyFinancialReportRepository' into featu…
anatolyshipitz Jun 12, 2025
267945a
Merge branch 'main' into feature/add-sendReportToSlack-activity
anatolyshipitz Jul 1, 2025
4cd5888
Refactor WeeklyFinancialReportRepository for improved report generation
anatolyshipitz Jul 2, 2025
6639af9
Enhance weekly financial reports workflow to include Slack reporting
anatolyshipitz Jul 2, 2025
a0affa5
Merge branch 'main' into feature/add-slack-reporting
anatolyshipitz Jul 3, 2025
0a1cd75
Merge branch 'main' into feature/add-slack-reporting
anatolyshipitz Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,32 +8,40 @@ import { weeklyFinancialReportsWorkflow } from './weeklyFinancialReports.workflo
vi.mock('@temporalio/workflow', () => {
const getTargetUnitsMock = vi.fn();
const fetchFinancialAppDataMock = vi.fn();
const sendReportToSlackMock = vi.fn();

return {
proxyActivities: () => ({
getTargetUnits: getTargetUnitsMock,
fetchFinancialAppData: fetchFinancialAppDataMock,
sendReportToSlack: sendReportToSlackMock,
}),
__getTargetUnitsMock: () => getTargetUnitsMock,
__getFetchFinancialAppDataMock: () => fetchFinancialAppDataMock,
__getSendReportToSlackMock: () => sendReportToSlackMock,
};
});

describe('weeklyFinancialReportsWorkflow', () => {
type WorkflowModuleWithMock = typeof workflowModule & {
__getTargetUnitsMock: () => ReturnType<typeof vi.fn>;
__getFetchFinancialAppDataMock: () => ReturnType<typeof vi.fn>;
__getSendReportToSlackMock: () => ReturnType<typeof vi.fn>;
};
const getTargetUnitsMock = (
workflowModule as WorkflowModuleWithMock
).__getTargetUnitsMock();
const fetchFinancialAppDataMock = (
workflowModule as WorkflowModuleWithMock
).__getFetchFinancialAppDataMock();
const sendReportToSlackMock = (
workflowModule as WorkflowModuleWithMock
).__getSendReportToSlackMock();

beforeEach(() => {
getTargetUnitsMock.mockReset();
fetchFinancialAppDataMock.mockReset();
sendReportToSlackMock.mockReset();
});

it('throws AppError for invalid group name', async () => {
Expand Down Expand Up @@ -72,12 +80,17 @@ describe('weeklyFinancialReportsWorkflow', () => {
fetchFinancialAppDataMock.mockResolvedValueOnce({
fileLink: 'result.json',
});
sendReportToSlackMock.mockResolvedValueOnce('slack-link.json');
const result = await weeklyFinancialReportsWorkflow(
GroupNameEnum.SD_REPORT,
);

expect(result).toBe('result.json');
expect(result).toBe('slack-link.json');
expect(getTargetUnitsMock).toHaveBeenCalledWith(GroupNameEnum.SD_REPORT);
expect(fetchFinancialAppDataMock).toHaveBeenCalledWith('file.json');
expect(sendReportToSlackMock).toHaveBeenCalledWith(
'file.json',
'result.json',
);
});
});
11 changes: 5 additions & 6 deletions workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@ import { AppError } from '../../common/errors';
import { GroupName } from '../../common/types';
import { GroupNameEnum } from '../../configs/weeklyFinancialReport';

const { getTargetUnits, fetchFinancialAppData } = proxyActivities<
typeof activities
>({
startToCloseTimeout: '10 minutes',
});
const { getTargetUnits, fetchFinancialAppData, sendReportToSlack } =
proxyActivities<typeof activities>({
startToCloseTimeout: '10 minutes',
});

export async function weeklyFinancialReportsWorkflow(
groupName: GroupName,
Expand All @@ -23,5 +22,5 @@ export async function weeklyFinancialReportsWorkflow(
const targetUnits = await getTargetUnits(groupName);
const finData = await fetchFinancialAppData(targetUnits.fileLink);

return finData.fileLink;
return await sendReportToSlack(targetUnits.fileLink, finData.fileLink);
}