[629] Use Client Name as anchor text for targeted link#128
Merged
yuramax merged 2 commits intoMay 28, 2025
Conversation
Contributor
📝 Walkthrough## Walkthrough
The changes update the styling of case study components and modify the template to conditionally render the case study title as a link to the client website if available. Link styles are consolidated, and external link security attributes are improved.
## Changes
| File(s) | Change Summary |
|-----------------------------------------------------------------------|----------------------------------------------------------------------------------------------------|
| website/modules/asset/ui/src/scss/_cases.scss | Adjusted placeholder image sizing, updated `.cs_details-page` and `.cs_full-details-card` `.cname a` link styles, removed `.client-website-link` class, consolidated link styles under `.prod-link`. |
| website/modules/case-studies-page/views/show.html | Case study title is now conditionally a link to the client website; added security attributes (`target="_blank"`, `rel="noopener noreferrer"`) to external links. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant CaseStudyPage
User->>CaseStudyPage: Visit case study page
CaseStudyPage->>CaseStudyPage: Check if clientWebsite exists
alt clientWebsite exists
CaseStudyPage->>User: Render title as link to client website
else clientWebsite missing
CaseStudyPage->>User: Render title as plain text
endPossibly related PRs
Suggested reviewers
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
website/modules/asset/ui/src/scss/_cases.scss (1)
549-558: Consolidate link styles and add focus state for.cname aGood addition of default gray color and underline-on-hover for client name links. For maintainability and accessibility, consider:
- Extracting these common link styles into a shared mixin (similar to
.prod-link).- Adding a visible focus outline (e.g.,
outline: 2px solid $focus-color) to support keyboard navigation.website/modules/case-studies-page/views/show.html (1)
68-72: Improve anchor text for externalprodLinkAdding
rel="noopener noreferrer"is great for security. However, displaying the raw URL as link text can be verbose. Consider using more descriptive anchor text—like"View Live Site"or the client’s name—to enhance readability, SEO, and overall UX.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
website/modules/asset/ui/src/scss/_cases.scss(3 hunks)website/modules/case-studies-page/views/show.html(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: e2e-tests
- GitHub Check: lint
- GitHub Check: unit-tests
- GitHub Check: security-scan
🔇 Additional comments (1)
website/modules/asset/ui/src/scss/_cases.scss (1)
362-364: Approve layout adjustments for placeholder containerThe switch from a fixed height to
max-height: 240pxwithheight: 100%, plus the increased top padding at large breakpoints, aligns the placeholder container size with the updated image dimensions. Ensure you test across breakpoints to confirm there are no overflow or alignment issues.Also applies to: 372-372
🔍 Vulnerabilities of
|
| digest | sha256:82e6fc952305768b6615227b81f10d43b4b1bba7d6b15e55106e466619536e56 |
| vulnerabilities |     |
| platform | linux/amd64 |
| size | 284 MB |
| packages | 935 |
📦 Base Image node:23-alpine
| also known as |
|
| digest | sha256:169ee1b69bd3f5c7c8508a9919e8b367bba9dc7fa9a03097ec9f85d2e8179631 |
| vulnerabilities |  |
Description
| ||||||||||||
Description
| ||||||||||||
Description
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the use of client names as anchor text for targeted links.