Skip to content

fix: disable module shortcuts to resolve conflicts - #180

Merged
Anton-88 merged 2 commits into
mainfrom
fix/shortcut-conflicts
Jul 1, 2025
Merged

fix: disable module shortcuts to resolve conflicts#180
Anton-88 merged 2 commits into
mainfrom
fix/shortcut-conflicts

Conversation

@VitalyyP

@VitalyyP VitalyyP commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Screenshot 2025-06-24 at 14 46 05 - to avoid this message in terminal:

  • Add shortcut: false to case-studies module
  • Add shortcut: false to cases-tags module
  • Add shortcut: false to categories module
  • Add shortcut: false to team-members module
  • Add shortcut: false to testimonials module

@VitalyyP
fix: disable module shortcuts to resolve conflicts
ab059ca 
- Add shortcut: false to case-studies module
- Add shortcut: false to cases-tags module
- Add shortcut: false to categories module
- Add shortcut: false to team-members module
- Add shortcut: false to testimonials module

This resolves the shortcut conflicts detected in admin-bar between:
- G,T: team-members:manager and testimonials:manager
- G,C: cases-tags:manager, case-studies:manager, and categories:manager
@VitalyyP
VitalyyP requested a review from killev as a code owner June 23, 2025 09:32
@coderabbitai

coderabbitai Bot commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The changes disable keyboard shortcuts for several content modules by setting the shortcut option to false in their configuration objects. Additionally, the "Team Members" module updates its label and plural label. No other logic, fields, or control flow are affected in these modules.

Changes

Files Change Summary
website/modules/case-studies/index.js Added shortcut: false to options object, disabling shortcut for "Case Study" piece type.
website/modules/cases-tags/index.js Changed shortcut option from 'G,H' to false, disabling shortcut for "Case Study Tag" type.
website/modules/categories/index.js Added shortcut: false to options object, disabling shortcut for categories piece type.
website/modules/team-members/index.js Changed label and plural label to "Team Member(s)", set shortcut to false instead of 'G,K'.
website/modules/testimonials/index.js Added shortcut: false to options object, disabling shortcut for testimonials piece type.

Suggested reviewers

  • yuramax
  • IhorMasechko
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3bcb9c4 and ab059ca.

📒 Files selected for processing (5)
  • website/modules/case-studies/index.js (1 hunks)
  • website/modules/cases-tags/index.js (1 hunks)
  • website/modules/categories/index.js (1 hunks)
  • website/modules/team-members/index.js (1 hunks)
  • website/modules/testimonials/index.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: security-scan
  • GitHub Check: lint
  • GitHub Check: e2e-tests
  • GitHub Check: unit-tests
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)
🔇 Additional comments (5)
website/modules/categories/index.js (1)

6-6: LGTM! Shortcut correctly disabled.

The addition of shortcut: false appropriately disables keyboard shortcuts for the categories module, aligning with the PR objective to resolve shortcut conflicts.

website/modules/case-studies/index.js (1)

11-11: LGTM! Consistent shortcut disabling.

The addition of shortcut: false correctly disables keyboard shortcuts for the case-studies module, maintaining consistency with the other modules being updated in this PR.

website/modules/testimonials/index.js (1)

9-9: LGTM! Shortcut properly disabled.

The addition of shortcut: false correctly disables keyboard shortcuts for the testimonials module, consistent with the PR's goal of resolving shortcut conflicts.

website/modules/cases-tags/index.js (1)

8-8: LGTM! Existing shortcut removed to resolve conflicts.

The change from shortcut: 'G,H' to shortcut: false removes the previously configured keyboard shortcut, which directly addresses the PR objective of resolving shortcut conflicts.

website/modules/team-members/index.js (1)

5-7: LGTM! Shortcut disabled and labels improved.

The changes accomplish two improvements:

  1. Shortcut conflict resolution: Removes the 'G,K' keyboard shortcut by setting shortcut: false, aligning with the PR objective
  2. Label enhancement: Updates from "Team Leader/Team Leaders" to "Team Member/Team Members", providing more inclusive and accurate terminology

Both changes are well-implemented and beneficial.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@VitalyyP VitalyyP self-assigned this Jun 23, 2025
@github-actions

github-actions Bot commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown

🔍 Vulnerabilities of apostrophe-cms:test

📦 Image Reference apostrophe-cms:test
digestsha256:4062d7e5bf1b1e316220e6831e5c3577e50f8487196c1b6f0c17fc3ba5cde81d
vulnerabilitiescritical: 0 high: 3 medium: 0 low: 0
platformlinux/amd64
size290 MB
packages976
📦 Base Image node:23-alpine
also known as
  • 23-alpine3.22
  • 23.11-alpine
  • 23.11-alpine3.22
  • 23.11.1-alpine
  • 23.11.1-alpine3.22
digestsha256:b9d38d589853406ff0d4364f21969840c3e0397087643aef8eede40edbb6c7cd
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 1
critical: 0 high: 1 medium: 0 low: 0 async 1.5.2 (npm)

pkg:npm/async@1.5.2

high 7.8: CVE--2021--43138 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range<2.6.4
Fixed version2.6.4, 3.2.2
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score0.907%
EPSS Percentile75th percentile
Description

A vulnerability exists in Async through 3.2.1 (fixed in 3.2.2), which could let a malicious user obtain privileges via the mapValues() method.

critical: 0 high: 1 medium: 0 low: 0 connect-multiparty 2.2.0 (npm)

pkg:npm/connect-multiparty@2.2.0

high 7.8: CVE--2022--29623 Unrestricted Upload of File with Dangerous Type

Affected range<=2.2.0
Fixed versionNot Fixed
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score0.334%
EPSS Percentile56th percentile
Description

An arbitrary file upload vulnerability in the file upload module of Express Connect-Multiparty 2.2.0 allows attackers to execute arbitrary code via a crafted PDF file. NOTE: the Supplier has not verified this vulnerability report.

critical: 0 high: 1 medium: 0 low: 0 async 0.9.2 (npm)

pkg:npm/async@0.9.2

high 7.8: CVE--2021--43138 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range<2.6.4
Fixed version2.6.4, 3.2.2
CVSS Score7.8
CVSS VectorCVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score0.907%
EPSS Percentile75th percentile
Description

A vulnerability exists in Async through 3.2.1 (fixed in 3.2.2), which could let a malicious user obtain privileges via the mapValues() method.

yuramax
yuramax approved these changes Jun 24, 2025
View reviewed changes

@yuramax yuramax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console is clean, LGTM! 👍

IhorMasechko
IhorMasechko approved these changes Jun 24, 2025
View reviewed changes

@IhorMasechko IhorMasechko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Anton-88
Anton-88 approved these changes Jun 24, 2025
View reviewed changes

@Anton-88 Anton-88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

killev
killev approved these changes Jul 1, 2025
View reviewed changes

@killev killev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Anton-88
Anton-88 merged commit 2293659 into main Jul 1, 2025
11 checks passed
@Anton-88
Anton-88 deleted the fix/shortcut-conflicts branch July 1, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@killev killev killev approved these changes
@IhorMasechko IhorMasechko IhorMasechko approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
+2 more reviewers
@yuramax yuramax yuramax approved these changes
@Anton-88 Anton-88 Anton-88 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@VitalyyP VitalyyP

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VitalyyP @yuramax @killev @Anton-88 @IhorMasechko