Conversation
pallyoung
marked this pull request as ready for review
August 17, 2026 06:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
desktop-channel-modern.json/modern.ymlRoot cause
Shell 0.1.1's electron-updater download path stalls even for tiny full-file probes, so blockmap and bootstrap fallbacks cannot reliably migrate that installed Shell. The legacy channel must avoid requesting a Shell download at all.
Impact
Existing Shell 0.1.1 installations receive Runtime 0.5.9 automatically, then install Shell 0.1.2 once manually. Fresh 0.1.2 installations use the modern channel and full installer downloads. Windows builds remain unsigned when release input
windows_signing=false, so Windows will show an Unknown publisher warning.Validation
pnpm changeset:validatepnpm ci:typecheckpnpm ci:buildFull local lint/test are affected by the Windows checkout's CRLF conversion and existing platform-specific tests; PR CI is the authoritative Linux gate.