Conversation
# Conflicts: # packages/server/src/server.ts # packages/server/src/ws/dispatch.ts # packages/web/src/app/providers.tsx # packages/web/src/features/code-editor/actions/use-code-editor-actions.ts # packages/web/src/features/workspace/views/shared/file-tree-panel.test.tsx
- Anchor stripCodeFence so a mid-payload ``` snippet inside a string value (e.g. guidance) no longer destroys the surrounding JSON. - Auto-repair literal control characters (\n, \r, \t, other <0x20) that appear inside JSON string literals, so payloads like `"guidance":"line1<LF>line2"` no longer fail with "Unterminated string in JSON at position X". - Log the raw payload preview on parse failure and tag the error with code "supervisor_eval_failed" so the existing retryOnEvaluatorError path picks it up instead of dropping the supervisor into an error state.
The workspace watcher recursively watched `.git/`, which on Windows let chokidar race transient files like `.git/index.lock` and emit `EPERM: operation not permitted, watch '...index.lock'`. With no `error` listener on the FSWatcher, EventEmitter turned it into an uncaughtException. - Tighten DEFAULT_WATCHER_IGNORED_PATTERNS to skip `.git/index.lock` / `.git/**/*.lock` / `.git/objects` / `.git/lfs` / `.git/logs` / `.git/hooks` / `.git/info`. Branch and worktree state (HEAD, refs/, packed-refs, worktrees/, index, config) is still observed so the UI keeps reacting to git operations. - Attach an `error` listener that swallows transient FS error codes (EPERM/ENOENT/EBUSY/EACCES) at debug level and surfaces unknown errors via `logger.warn`. The watcher now accepts an optional `WatcherLogger`; WorkspaceManager late-binds Fastify's `app.log` via a new `setLogger`, mirroring the existing wsHub pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developbranch intomaindevelopTest Plan