Report the flag name as typed in deprecation warnings - #500
Open
hdimer wants to merge 1 commit into
Open
Conversation
When a NormalizeFunc aliases a flag name, using the alias for a deprecated flag printed the canonical name rather than the one the user typed. Parse passed the normalized flag.Name into Set, so the typed name was lost before the warning was built. Thread the typed name through the internal parseFunc so the warning reports it. Long flags report the typed alias; shorthands keep the canonical long name. Public Set/ParseAll signatures are unchanged. Fixes spf13#279
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279.
With an alias from
SetNormalizeFunc, using the alias for a deprecated flag printed the canonical name rather than the one typed:Parse's callback passedflag.NameintoSet, so the typed name was gone before the warning was built. This threads the typed name through the internalparseFuncso the warning reports it. Long flags report the typed alias; shorthands keep the canonical long name (no alias to report). PublicSet/ParseAllsignatures are unchanged; callingSetdirectly with an alias now echoes that alias.Added
TestDeprecatedFlagUsageAlias.Used AI assistance on this; I reviewed and tested it.