Fix _toctree_copy with multi level 'only' nodes. #13133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudD-FR
force-pushed
the
master
branch
3 times, most recently
from
b1a10a0 to
8f8b0ac
Compare
…des. When copying toc tree, 'only' nodes should not be copied, but previous implementation always considered 'only' node children as duplicable nodes which is wrong when 'only' nodes is parent of other 'only' nodes.
Author
|
@AA-Turner any issue I should be aware about this PR? I have no answer since a while now |
Member
|
Thank you for this PR! I think the same problem was fixed in #13663. A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying toc tree, 'only' nodes should not be copied, but previous implementation always considered 'only' node children as duplicable nodes which is wrong when 'only' nodes is parent of other 'only' nodes.
Subject: Fix _toctree_copy with multi level 'only' nodes.
Feature or Bugfix
Purpose
When copying toc tree, 'only' nodes should not be copied, but previous implementation always considered 'only' node children as duplicable nodes which is wrong when 'only' nodes is parent of other 'only' nodes.
Detail
Split
_toctree_copyfunction in two parts:_toctree_copyduplicate nodes as previously but duplicates its children using the next function._toctree_copy_childrenhandle each node children and takes the decision about copying current node or not. In 'only' node case, this function is called recursively.Relates