Add TOC object entry support for C domain #13497
Merged
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynerd
force-pushed
the
c-domain-entries
branch
from
1f2b8ae to
fdc0e14
Compare
Contributor
Author
|
The CI is failing in the same way on Master as well as in this PR, thus I think that my changes introduce regression. |
AA-Turner
requested changes
May 12, 2025
Member
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
Please add tests and a CHANGES entry.
A
This is based on the C++ implementation. Implements sphinx-doc#11424
Contributor
Author
I have added a mention to CHANGES, but can you please point me to tests that deal with TOC entries for other domains? I based this change on CPP implementation, thus I tried to look for CPP tests as well, but I couldn't figure out where this is tested. @AA-Turner ? |
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is based on the C++ implementation.
References