Tests: isolate a pair of HTML build 'numfig' test cases #14100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
(more specifically: this is because I have not determined a way to replicate the same failure locally) |
Contributor
Author
|
Thanks @AA-Turner - I'll monitor upcoming CI test results to try to get a sense for whether this has resolved the problem. |
Contributor
Author
|
@AA-Turner argh; I've noticed that I removed this decorator from the wrong two test cases. The test case I meant to isolate is |
This was referenced Nov 27, 2025
AA-Turner
added a commit
that referenced
this pull request
Nov 27, 2025
This reverts commit 828bdca.
AA-Turner
pushed a commit
that referenced
this pull request
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Recently the
test_numfig_disabled_warntest case has been flaky; although some of the intermittent failures have been noted fordocutilsHEAD, I've also noticed it occurring with other versions ofdocutilstoo.Some example failure logs include:
docutilsHEAD: https://github.com/sphinx-doc/sphinx/actions/runs/18772174723/job/53603139421#step:10:4828docutilsv0.20: https://github.com/sphinx-doc/sphinx/actions/runs/19662374866/job/56311219423#step:10:4879This pull request experiments with removal of the use of a shared build for the problem test case and another test that it shares with.
NB: I am not certain that this will fix the problem; we may need to re-run the tests a few times with this in place (or perhaps GitHub Actions CI will fail first time after I open this pull request...?).
cc @jfbu @haampie
References