Skip to content

feat: Add HashJoin accumulator display, HashJoin::recreate_with_accumulator#117

Merged
peasee merged 5 commits into
spiceai-50from
fix/add-hash-accumulator-display
Nov 27, 2025
Merged

feat: Add HashJoin accumulator display, HashJoin::recreate_with_accumulator#117
peasee merged 5 commits into
spiceai-50from
fix/add-hash-accumulator-display

Conversation

@peasee

@peasee peasee commented Nov 27, 2025

Copy link
Copy Markdown
  • Extends CollectLeftAccumulator with some name trait methods
  • Displays the accumulator name in the join Debug and DisplayAs
  • Adds a HashJoinExec function recreate_with_accumulator that retains the existing HashJoinExec as-is but returns a new instance of it with an updated generic type for the CollectLeftAccumulator

@peasee peasee self-assigned this Nov 27, 2025
@peasee peasee added the enhancement New feature or request label Nov 27, 2025
@peasee peasee changed the title feat: Add HashJoin accumulator display feat: Add HashJoin accumulator display, HashJoin::recreate_with_accumulator Nov 27, 2025
@peasee
peasee merged commit 97ea01e into spiceai-50 Nov 27, 2025
@peasee
peasee deleted the fix/add-hash-accumulator-display branch November 27, 2025 11:39
lukekim pushed a commit that referenced this pull request Jan 10, 2026
…mulator` (#117)

* fix: Add hash accumulator display

* fix: Add HashJoinExec::recreate_with_accumulator

* fix

* fix

* chore: Clippy
lukekim pushed a commit that referenced this pull request Feb 13, 2026
…mulator` (#117)

* fix: Add hash accumulator display

* fix: Add HashJoinExec::recreate_with_accumulator

* fix

* fix

* chore: Clippy
lukekim pushed a commit that referenced this pull request Feb 19, 2026
…mulator` (#117)

* fix: Add hash accumulator display

* fix: Add HashJoinExec::recreate_with_accumulator

* fix

* fix

* chore: Clippy
lukekim pushed a commit that referenced this pull request Feb 26, 2026
…mulator` (#117)

* fix: Add hash accumulator display

* fix: Add HashJoinExec::recreate_with_accumulator

* fix

* fix

* chore: Clippy
sgrebnov added a commit that referenced this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants