Skip to content

Limit the number of pg/mysql connections an app can have across instances#3546

Open
rylev wants to merge 1 commit into
mainfrom
pg-mysql-semaphore
Open

Limit the number of pg/mysql connections an app can have across instances#3546
rylev wants to merge 1 commit into
mainfrom
pg-mysql-semaphore

Conversation

@rylev
Copy link
Copy Markdown
Collaborator

@rylev rylev commented May 28, 2026

Same thing as #3545 but for MySQL and Postgres.

…nces

Signed-off-by: Ryan Levick <rlevick@akamai.com>
@rylev rylev requested a review from lann May 28, 2026 15:05
@lann
Copy link
Copy Markdown
Collaborator

lann commented May 28, 2026

Should this be a single connection limit across all interfaces? 😬

@rylev
Copy link
Copy Markdown
Collaborator Author

rylev commented May 29, 2026

@lann Yes I think so but not exclusively. I think it is useful to have individual limits for factors and a global limit. This would give users the ability to do things like limit total connections to say 100 but limit Redis specifically to 5. I went ahead and implemented this in 626b698.

If the idea of a combined global and factor specific connections limiting system sounds good to you, the question becomes: how do you best want to review this. Would you prefer if I collapsed #3537, #3545, #3546, and 626b698 all into one branch and then opened up a new PR? Such a PR would be pretty big but then you'd have all the context in one place. Otherwise, we could merge the factor specific PRs first and then open up a PR for 626b698 separately.

@lann
Copy link
Copy Markdown
Collaborator

lann commented May 29, 2026

Assuming 626b698 is refactoring significant chunks of the other PRs I think a single PR would mean less redundant review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants