Limit the number of pg/mysql connections an app can have across instances#3546
Limit the number of pg/mysql connections an app can have across instances#3546rylev wants to merge 1 commit into
Conversation
…nces Signed-off-by: Ryan Levick <rlevick@akamai.com>
|
Should this be a single connection limit across all interfaces? 😬 |
|
@lann Yes I think so but not exclusively. I think it is useful to have individual limits for factors and a global limit. This would give users the ability to do things like limit total connections to say 100 but limit Redis specifically to 5. I went ahead and implemented this in 626b698. If the idea of a combined global and factor specific connections limiting system sounds good to you, the question becomes: how do you best want to review this. Would you prefer if I collapsed #3537, #3545, #3546, and 626b698 all into one branch and then opened up a new PR? Such a PR would be pretty big but then you'd have all the context in one place. Otherwise, we could merge the factor specific PRs first and then open up a PR for 626b698 separately. |
|
Assuming 626b698 is refactoring significant chunks of the other PRs I think a single PR would mean less redundant review. |
Same thing as #3545 but for MySQL and Postgres.