Deprecate max_concurrent_requests#3547
Draft
rylev wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Ryan Levick <rlevick@akamai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting to draft so we can let #3545, #3546, and #3537 settle first since this brings outbound http into line with the changes to the other factors made in those PRs.
This deprecates the
max_concurrent_requestsruntime config setting to bring it more into line with the naming conventions for other factors introduced in #3545, #3546, and #3537. It also gets rid of the weird "0 means 1" semantics in the newly introduced option that I am responsible for despite @lann telling me it was a bad idea (I SHOULD HAVE LISTENED).This is a backwards compatible change, and we can consider removing the option completely in some future release.