Workflow to finalize Wasmtime upgrade - #3627
Merged
Merged
Conversation
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Collaborator
That's assurance enough for me! |
itowlson
reviewed
Jul 21, 2026
itowlson
left a comment
itowlson
left a comment
Collaborator
There was a problem hiding this comment.
Per your comment about improving confidence, my suggestions would be:
- Split the bump and backport-patch. That gives us an opportunity to review the bump PR, and address any concerns, before kicking off the backport. After several months of everything going perfectly smoothly, as it surely will, we can review whether to re-combine them.
- Begin with the manual (
workflow_dispatch) trigger only. That means we can run it at a time of our choosing when we are ready to keep an eye out for any shenanigans. Move to automatic later, when our confidence is high.
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
itowlson
approved these changes
Jul 22, 2026
itowlson
left a comment
itowlson
left a comment
Collaborator
There was a problem hiding this comment.
You might want to get someone else to look at the bash, and I have a couple of suggestions, but generally LGTM - thanks!
| log "Pushed crates.io update to ${pr_branch}" | ||
| } | ||
|
|
||
| cmd_backport() { |
Collaborator
There was a problem hiding this comment.
Can we leverage the existing backport script for this?
Collaborator
Author
There was a problem hiding this comment.
Not very cleanly. The backport job here also bumps the version for the patch release.
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
fibonacci1729
enabled auto-merge (squash)
July 22, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at adding a workflow to complement the
bump-wasmtimeautomation.I broke this up into a manual workflow_dispatch workflow. There are two phases
updateandbackport. Theupdatephase updates the PR created from the bump-wasmtime workflow to point at the released crates.io version. Thebackportjob can then be run to backport the merged PR from theupdatephase to the latest release branch. This backport PR will contain the patch version bump as well. All that is left is to push the tag to cut the release.