fix: use a valid mtplx scheduler mode in the example preset - #164
Merged
Conversation
mtplx 2.11.1 removed the old serial/parallel/concurrent scheduler modes, so the example preset's 'scheduler-mode = parallel' made 'spinloop serve' fail with an invalid choice. Use 'ar_batch' (mtplx's coding-agent scheduling mode) in the example preset and its tests, and stop pinning an exact mode list in the docs so they do not rot again when mtplx renames its modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
spinloop servefailing when the mtplx example preset referenced a scheduler mode that mtplx has since removed.Summary
serial/parallel/concurrent--scheduler-modechoices, so the shipped example preset (scheduler-mode = parallel) madespinloop serveexit with an invalid choice.ar_batchin the example preset and the two serve test fixtures that mirror it.docs/commands/serve.mdand the example README; both now note thatservepasses the value through unchecked and thatmtplx serve --helplists the modes the installed build offers.Implementation details
ar_batchwas chosen because it is the mode behind mtplx'sopen_code_fairscheduling policy, its configuration for coding-agent (opencode) traffic, which is what this example serves. The docs no longer enumerate the valid modes: that pinned list is what broke when mtplx renamed its modes. The main specs never pinned the values, so they needed no change.