Fix unit test error on latest php 8.4 and php 8.5 build - #1298
Conversation
|
@roxblnfk ready to merge 👍. Rector notice is handled on PR: |
|
Thanks! I think it's better to fix the tests rather than the renderer itself: both string representations are valid PHP expressions that evaluate to the same value, so the generated proxy code was never broken — only the literal assertion in the test. I've pushed an update that makes the test accept both variants via |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
=========================================
Coverage 90.65% 90.65%
Complexity 6703 6703
=========================================
Files 876 876
Lines 18978 18978
=========================================
Hits 17204 17204
Misses 1774 1774 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@roxblnfk yes 👍 |
What was changed
Related by latest build error
https://github.com/spiral/framework/actions/runs/30915207986/job/92011479490?pr=1297#step:11:84
Why?
To fix latest build that seems due to latest php release.
Checklist
Documentation