Skip to content

[Upstream] Fix for tinymce editor not being initialized on richtext fields#2

Merged
astratagem merged 4 commits into
spiritedmediafrom
spiritedmedia-collapsed-richtext-tinymce-reinit
May 11, 2018
Merged

[Upstream] Fix for tinymce editor not being initialized on richtext fields#2
astratagem merged 4 commits into
spiritedmediafrom
spiritedmedia-collapsed-richtext-tinymce-reinit

Conversation

@astratagem
Copy link
Copy Markdown

@astratagem astratagem commented May 10, 2018

Cherry-picked version of alleyinteractive#628 without all the new stuff so we can avoid deprecation warnings for Fieldmanager_Context_Page (see alleyinteractive#157).

QA

You'll have to check this out locally:

# From your local environment root
cd wp-content/plugins/wordpress-fieldmanager
git fetch
git checkout spiritedmedia-collapsed-richtext-tinymce-reinit

Is the issue described in https://github.com/spiritedmedia/spiritedmedia/pull/2591#issuecomment-388175593 fixed?

@danielbachhuber
Copy link
Copy Markdown

danielbachhuber commented May 10, 2018

👋

(I somehow was subscribed to this repo, so thought I'd say hello)

@astratagem
Copy link
Copy Markdown
Author

Hello! Thanks for dropping by!

Copy link
Copy Markdown

@kingkool68 kingkool68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍Works as intended.

@kingkool68 kingkool68 assigned astratagem and unassigned kingkool68 May 11, 2018
@astratagem astratagem merged commit d13a431 into spiritedmedia May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants