-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(storage): add composable shared storage backends #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ian-pascoe
wants to merge
5
commits into
main
Choose a base branch
from
feat/portable-cloud-runtime-deployment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
163ca3e
feat(storage): add composable shared authorities
ian-pascoe 0c30178
fix(storage): harden shared authority scaling and recovery
ian-pascoe 1755f89
fix(storage): recover transient S3 reads in provider matrix
ian-pascoe 47c69bf
fix(storage): canonicalize receipt export ordering
ian-pascoe 4011081
refactor(storage): expose provider-shaped configuration
ian-pascoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@caplets/core": minor | ||
| caplets: minor | ||
| --- | ||
|
|
||
| Add composable shared storage for self-hosted deployments: select one global provider-shaped filesystem, SQLite, PostgreSQL, or S3-compatible `storage` configuration while composing immutable staged Caplets. The core runtime now exposes async storage assembly, generation/health coordination, Storage-facing dashboard management, and explicit inventory, migration, backup, restore, and cutover operations. Document provider prerequisites and keep AWS S3/Cloudflare R2 live validation separate from deterministic PostgreSQL/MinIO evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
Set
persist-credentials: falseonactions/checkout.Neither checkout disables credential persistence, so the
GITHUB_TOKENis written to.git/configand remains available to any later step. This is especially relevant forstorage-provider-live, which also loads long-lived cloud secrets into the job environment.🔒️ Proposed hardening
- name: Checkout uses: actions/checkout@v7 + with: + persist-credentials: falseAs per static analysis (zizmor
artipacked: does not setpersist-credentials: false).Also applies to: 94-95
🧰 Tools
🪛 zizmor (1.26.1)
[warning] 58-59: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Source: Linters/SAST tools