Skip to content

Conversation

@gturri
Copy link
Contributor

@gturri gturri commented Jan 20, 2013

In particular:

  • the timeout is a per-profile option, hat way it's possible to have different timeouts for a big and a small wiki
  • Migration should be transparent for users. Ie: if a profile doesn't have a timeout specified, we'll use a default ont

splitbrain added a commit that referenced this pull request Jan 20, 2013
@splitbrain splitbrain merged commit 42b1deb into splitbrain:master Jan 20, 2013
eduardomozart added a commit to eduardomozart/dokuwiki-plugin-sync that referenced this pull request Mar 7, 2024
This PR fixes the following error on plugin mainpage:

```
2024-03-07 15:35:05
E_COMPILE_ERROR: Declaration of dokuwiki\plugin\sync\Client::query() must be compatible with dokuwiki\Remote\IXR\Client::query(...$args)
/home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(26)
#0 [internal function]: dokuwiki\ErrorHandler::fatalShutdown()
splitbrain#1 {main}
```

Also, this adds a "@" before geterrorCode() call because it was failing on 200 status and the following errors was being thrown on page when PHP "display_errors" was set to true (the error isn't shown on page anymore but it's logged on DokuWiki logs):

```
2024-03-07 15:33:39
E_WARNING: Attempt to read property "code" on null
/home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182)
#0 /home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182): dokuwiki\ErrorHandler::errorHandler(2, 'Attempt to read...', '/home/robertinh...', 182)
splitbrain#1 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(28): IXR\Client\Client->getErrorCode()
splitbrain#2 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(49): dokuwiki\plugin\sync\Client->query('dokuwiki.login', 'username', 'password')
splitbrain#3 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(22): dokuwiki\plugin\sync\Client->login('username', 'password')
splitbrain#4 /home/robertinho/public_html/wiki/lib/plugins/sync/Profile.php(38): dokuwiki\plugin\sync\Client->__construct('https://wiki.ne...', 'username', 'password', '180')
splitbrain#5 /home/robertinho/public_html/wiki/lib/plugins/sync/ProfileManager.php(30): dokuwiki\plugin\sync\Profile->__construct(Array)
splitbrain#6 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(113): dokuwiki\plugin\sync\ProfileManager->getProfile(0)
splitbrain#7 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(98): admin_plugin_sync->profileInfo()
splitbrain#8 /home/robertinho/public_html/wiki/inc/template.php(205): admin_plugin_sync->html()
splitbrain#9 /home/robertinho/public_html/wiki/inc/Action/Admin.php(43): tpl_admin()
splitbrain#10 /home/robertinho/public_html/wiki/inc/template.php(120): dokuwiki\Action\Admin->tplContent()
splitbrain#11 [internal function]: tpl_content_core('admin')
splitbrain#12 /home/robertinho/public_html/wiki/inc/Extension/Event.php(134): call_user_func_array('tpl_content_cor...', Array)
splitbrain#13 /home/robertinho/public_html/wiki/inc/Extension/Event.php(200): dokuwiki\Extension\Event->trigger('tpl_content_cor...', true)
splitbrain#14 /home/robertinho/public_html/wiki/inc/template.php(102): dokuwiki\Extension\Event::createAndTrigger('TPL_ACT_RENDER', 'admin', 'tpl_content_cor...')
splitbrain#15 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/tpl_parts/tpl_content.html(5): tpl_content(false)
splitbrain#16 /home/robertinho/public_html/wiki/inc/template.php(1785): include('/home/robertinh...')
splitbrain#17 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/main.php(42): tpl_includeFile('/home/robertinh...')
splitbrain#18 /home/robertinho/public_html/wiki/inc/actions.php(30): include('/home/robertinh...')
splitbrain#19 /home/robertinho/public_html/wiki/doku.php(131): act_dispatch()
splitbrain#20 {main}
2024-03-07 15:33:40
E_WARNING: Attempt to read property "code" on null
/home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182)
#0 /home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182): dokuwiki\ErrorHandler::errorHandler(2, 'Attempt to read...', '/home/robertinh...', 182)
splitbrain#1 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(28): IXR\Client\Client->getErrorCode()
splitbrain#2 /home/robertinho/public_html/wiki/lib/plugins/sync/Profile.php(71): dokuwiki\plugin\sync\Client->query('dokuwiki.getVer...')
splitbrain#3 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(114): dokuwiki\plugin\sync\Profile->getRemotVersion()
splitbrain#4 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(98): admin_plugin_sync->profileInfo()
splitbrain#5 /home/robertinho/public_html/wiki/inc/template.php(205): admin_plugin_sync->html()
splitbrain#6 /home/robertinho/public_html/wiki/inc/Action/Admin.php(43): tpl_admin()
splitbrain#7 /home/robertinho/public_html/wiki/inc/template.php(120): dokuwiki\Action\Admin->tplContent()
splitbrain#8 [internal function]: tpl_content_core('admin')
splitbrain#9 /home/robertinho/public_html/wiki/inc/Extension/Event.php(134): call_user_func_array('tpl_content_cor...', Array)
splitbrain#10 /home/robertinho/public_html/wiki/inc/Extension/Event.php(200): dokuwiki\Extension\Event->trigger('tpl_content_cor...', true)
splitbrain#11 /home/robertinho/public_html/wiki/inc/template.php(102): dokuwiki\Extension\Event::createAndTrigger('TPL_ACT_RENDER', 'admin', 'tpl_content_cor...')
splitbrain#12 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/tpl_parts/tpl_content.html(5): tpl_content(false)
splitbrain#13 /home/robertinho/public_html/wiki/inc/template.php(1785): include('/home/robertinh...')
splitbrain#14 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/main.php(42): tpl_includeFile('/home/robertinh...')
splitbrain#15 /home/robertinho/public_html/wiki/inc/actions.php(30): include('/home/robertinh...')
splitbrain#16 /home/robertinho/public_html/wiki/doku.php(131): act_dispatch()
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants