Handle error #18
Merged
Handle error #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the request for remote pages is a success but the one for media fails, then we have the error message "Failed to fetch remote file list" but the list of pages is displayed, and (if php warnings are enabled) we then have Warning: Invalid argument supplied for foreach() in sync/admin.php on line 546 It's therefore not quite clear for the user if it's a success or a failure (and in particular if he can go on) The goal of this patch is to keep only the "failed to fetch ..." error message
eduardomozart
added a commit
to eduardomozart/dokuwiki-plugin-sync
that referenced
this pull request
Mar 7, 2024
This PR fixes the following error on plugin mainpage: ``` 2024-03-07 15:35:05 E_COMPILE_ERROR: Declaration of dokuwiki\plugin\sync\Client::query() must be compatible with dokuwiki\Remote\IXR\Client::query(...$args) /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(26) #0 [internal function]: dokuwiki\ErrorHandler::fatalShutdown() splitbrain#1 {main} ``` Also, this adds a "@" before geterrorCode() call because it was failing on 200 status and the following errors was being thrown on page when PHP "display_errors" was set to true (the error isn't shown on page anymore but it's logged on DokuWiki logs): ``` 2024-03-07 15:33:39 E_WARNING: Attempt to read property "code" on null /home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182) #0 /home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182): dokuwiki\ErrorHandler::errorHandler(2, 'Attempt to read...', '/home/robertinh...', 182) splitbrain#1 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(28): IXR\Client\Client->getErrorCode() splitbrain#2 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(49): dokuwiki\plugin\sync\Client->query('dokuwiki.login', 'username', 'password') splitbrain#3 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(22): dokuwiki\plugin\sync\Client->login('username', 'password') splitbrain#4 /home/robertinho/public_html/wiki/lib/plugins/sync/Profile.php(38): dokuwiki\plugin\sync\Client->__construct('https://wiki.ne...', 'username', 'password', '180') splitbrain#5 /home/robertinho/public_html/wiki/lib/plugins/sync/ProfileManager.php(30): dokuwiki\plugin\sync\Profile->__construct(Array) splitbrain#6 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(113): dokuwiki\plugin\sync\ProfileManager->getProfile(0) splitbrain#7 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(98): admin_plugin_sync->profileInfo() splitbrain#8 /home/robertinho/public_html/wiki/inc/template.php(205): admin_plugin_sync->html() splitbrain#9 /home/robertinho/public_html/wiki/inc/Action/Admin.php(43): tpl_admin() splitbrain#10 /home/robertinho/public_html/wiki/inc/template.php(120): dokuwiki\Action\Admin->tplContent() splitbrain#11 [internal function]: tpl_content_core('admin') splitbrain#12 /home/robertinho/public_html/wiki/inc/Extension/Event.php(134): call_user_func_array('tpl_content_cor...', Array) splitbrain#13 /home/robertinho/public_html/wiki/inc/Extension/Event.php(200): dokuwiki\Extension\Event->trigger('tpl_content_cor...', true) splitbrain#14 /home/robertinho/public_html/wiki/inc/template.php(102): dokuwiki\Extension\Event::createAndTrigger('TPL_ACT_RENDER', 'admin', 'tpl_content_cor...') splitbrain#15 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/tpl_parts/tpl_content.html(5): tpl_content(false) splitbrain#16 /home/robertinho/public_html/wiki/inc/template.php(1785): include('/home/robertinh...') splitbrain#17 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/main.php(42): tpl_includeFile('/home/robertinh...') splitbrain#18 /home/robertinho/public_html/wiki/inc/actions.php(30): include('/home/robertinh...') splitbrain#19 /home/robertinho/public_html/wiki/doku.php(131): act_dispatch() splitbrain#20 {main} 2024-03-07 15:33:40 E_WARNING: Attempt to read property "code" on null /home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182) #0 /home/robertinho/public_html/wiki/vendor/kissifrot/php-ixr/src/Client/Client.php(182): dokuwiki\ErrorHandler::errorHandler(2, 'Attempt to read...', '/home/robertinh...', 182) splitbrain#1 /home/robertinho/public_html/wiki/lib/plugins/sync/Client.php(28): IXR\Client\Client->getErrorCode() splitbrain#2 /home/robertinho/public_html/wiki/lib/plugins/sync/Profile.php(71): dokuwiki\plugin\sync\Client->query('dokuwiki.getVer...') splitbrain#3 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(114): dokuwiki\plugin\sync\Profile->getRemotVersion() splitbrain#4 /home/robertinho/public_html/wiki/lib/plugins/sync/admin.php(98): admin_plugin_sync->profileInfo() splitbrain#5 /home/robertinho/public_html/wiki/inc/template.php(205): admin_plugin_sync->html() splitbrain#6 /home/robertinho/public_html/wiki/inc/Action/Admin.php(43): tpl_admin() splitbrain#7 /home/robertinho/public_html/wiki/inc/template.php(120): dokuwiki\Action\Admin->tplContent() splitbrain#8 [internal function]: tpl_content_core('admin') splitbrain#9 /home/robertinho/public_html/wiki/inc/Extension/Event.php(134): call_user_func_array('tpl_content_cor...', Array) splitbrain#10 /home/robertinho/public_html/wiki/inc/Extension/Event.php(200): dokuwiki\Extension\Event->trigger('tpl_content_cor...', true) splitbrain#11 /home/robertinho/public_html/wiki/inc/template.php(102): dokuwiki\Extension\Event::createAndTrigger('TPL_ACT_RENDER', 'admin', 'tpl_content_cor...') splitbrain#12 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/tpl_parts/tpl_content.html(5): tpl_content(false) splitbrain#13 /home/robertinho/public_html/wiki/inc/template.php(1785): include('/home/robertinh...') splitbrain#14 /home/robertinho/public_html/wiki/lib/tpl/readthedokus/main.php(42): tpl_includeFile('/home/robertinh...') splitbrain#15 /home/robertinho/public_html/wiki/inc/actions.php(30): include('/home/robertinh...') splitbrain#16 /home/robertinho/public_html/wiki/doku.php(131): act_dispatch() ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the request for remote pages is a success but the one for media fails,
then we have the error message "Failed to fetch remote file list" but the list of pages
is displayed, and (if php warnings are enabled) we then have
Warning: Invalid argument supplied for foreach() in sync/admin.php on line 546
It's therefore not quite clear for the user if it's a success or a failure
(and in particular if he can go on)
The goal of this patch is to keep only the "failed to fetch ..." error message