Skip to content

Conversation

@fietserwin
Copy link

The tests now run successfully on Windows, I hope they still do so as well on Linux...

@fietserwin
Copy link
Author

A few notes:

  • You require php5.4, but your tests use constructs of 5.5 (:::class) and 7.1 (return :void), so testing on 5.4 will be difficult.
  • The test testExtractWithArchiveStreamIsClosed() is expected to throw an ArchiveIOExceptin, but if the check on the open status of the archive fails it will stil throw so on the erroneous out path (i.e. on Linux :)), so you might be getting a false success.

@splitbrain
Copy link
Owner

Awesome! Thanks for your help.

Testing on older PHP versions is unfortunately not possible because old phpunit versions needed for old PHP versions are not compatible with newer ones. So it's not possible to write tests that run on old and new php unit releases...

@splitbrain splitbrain merged commit 0ca3e26 into splitbrain:windowstests Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants