Closed
Conversation
lizardoluis
commented
Mar 13, 2025
Comment on lines
+483
to
+489
| let file_source = if let Some(physical_predicate) = physical_predicate.clone() { | ||
| Arc::new( | ||
| ParquetSource::default().with_predicate(Arc::clone(&file_schema), physical_predicate), | ||
| ) | ||
| } else { | ||
| Arc::new(ParquetSource::default()) | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
Please double check if this is the proper way of creating this file_source.
lizardoluis
commented
Mar 13, 2025
Comment on lines
+577
to
+585
| let delete_file_source = | ||
| if let Some(physical_predicate) = physical_predicate.clone() { | ||
| Arc::new(ParquetSource::default().with_predicate( | ||
| Arc::clone(&delete_file_schema), | ||
| physical_predicate, | ||
| )) | ||
| } else { | ||
| Arc::new(ParquetSource::default()) | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
Check here too please
Collaborator
Author
|
Closing this because I opened the same upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.