Add functionality to specify a percentage of traffic that can be in the Split#87
Closed
fmotas wants to merge 13 commits intosplitio:developmentfrom
Closed
Conversation
added 13 commits
August 3, 2022 20:07
…dle conditions with the same type
Contributor
|
More info: #88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET SDK
What did you accomplish?
Now it is possible to set the percentage of traffic of a specific split in the yaml file using the node "size".
How do we test the changes introduced in this PR?
Running the unit tests or setting the size in your yaml file and checking the percentage of traffic set for your split locally.
Extra Notes
I followed the same pattern already used in the codebase, and I also added the new functionality in the
CreateConditionmethod making sure that it will not break any current use of it since the new parameter is optional.