Skip to content

Sort experiments on Dashboard so "active" ones without a winner appear first #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2013
Merged

Sort experiments on Dashboard so "active" ones without a winner appear first #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/split/dashboard.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ class Dashboard < Sinatra::Base
helpers Split::DashboardHelpers

get '/' do
@experiments = Split::Experiment.all
# Display experiments without a winner at the top of the dashboard
@experiments = Split::Experiment.all_active_first
# Display Rails Environment mode (or Rack version if not using Rails)
if Object.const_defined?('Rails')
@current_env = Rails.env.titlecase
Expand Down Expand Up @@ -44,4 +45,4 @@ class Dashboard < Sinatra::Base
redirect url('/')
end
end
end
end
5 changes: 5 additions & 0 deletions lib/split/experiment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ def self.all
Split.redis.smembers(:experiments).map {|e| find(e)}
end

# Return experiments without a winner (considered "active") first
def self.all_active_first
all.sort_by{|e| e.winner ? 1 : 0} # sort_by hack since true/false isn't sortable
end

def self.find(name)
if Split.redis.exists(name)
obj = self.new name
Expand Down