Skip to content

Conversation

@jonastemplestein
Copy link
Contributor

The first commit adds an include_rails_helper option that controls whether or not helper is mixed into rails controllers by default. Given that some method names are pretty generic (i.e. reset!) that could lead to conflicts (like in our case). As a workaround I added EncapsulatedHelper, which only exposes ab_test and ab_test_finished. It's a bit of a hack and I wouldn't generally use it, but perhaps it makes sense to refactor the helper so it exposes fewer, more namespaced methods and can be mixed into arbitrary classes, not just controllers? We mix EncapsulatedHelpers into models, as well, and use a custom persistence adapter that can deal with the different context.

The other two commits fix an issue where the resettable property from Split.configuration.experiments wasn't picked up by normalize_experiments.

My apologies, I tried to submit this as separate pull requests but I didn't find that option on GitHub.

Great job on this gem, by the way! Thanks for taking the time to publish it!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.83%) when pulling 67601fc on jonashuckestein:master into 08f61e3 on andrew:master.

@andrew
Copy link
Member

andrew commented Oct 5, 2013

Very nice, thanks

andrew added a commit that referenced this pull request Oct 5, 2013
Fix minor bugs, potentially refactor helper.rb
@andrew andrew merged commit 23e6df0 into splitrb:master Oct 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants