Fix minor bugs, potentially refactor helper.rb #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds an include_rails_helper option that controls whether or not helper is mixed into rails controllers by default. Given that some method names are pretty generic (i.e. reset!) that could lead to conflicts (like in our case). As a workaround I added
EncapsulatedHelper, which only exposesab_testandab_test_finished. It's a bit of a hack and I wouldn't generally use it, but perhaps it makes sense to refactor the helper so it exposes fewer, more namespaced methods and can be mixed into arbitrary classes, not just controllers? We mix EncapsulatedHelpers into models, as well, and use a custom persistence adapter that can deal with the different context.The other two commits fix an issue where the resettable property from Split.configuration.experiments wasn't picked up by normalize_experiments.
My apologies, I tried to submit this as separate pull requests but I didn't find that option on GitHub.
Great job on this gem, by the way! Thanks for taking the time to publish it!