Skip to content

Conversation

@IanVaughan
Copy link
Contributor

This mostly a code tidying PR; indentation, whitespace, and wrapping long lines.
Some of these are subjective, and as such you may not agree with them, thats fine, I was working on some other changes in your gem, and thought I'd separate this out to check if your happy with it.

Other small changes include

  1. Only rescuing from the error you expect
  2. Some rspec syntax sugar changes
  3. Removed 1 dup spec

@andrew
Copy link
Member

andrew commented Mar 11, 2014

Looks good, I always like pulls that remove more than they add 🎉

andrew pushed a commit that referenced this pull request Mar 11, 2014
@andrew andrew merged commit 9ec43fa into splitrb:master Mar 11, 2014
@IanVaughan IanVaughan deleted the tidy branch March 11, 2014 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants