Skip to content

Conversation

@brandonparsons
Copy link
Contributor

This is roughly what I'm trying to achieve, but it's not passing the tests I added in this format. Not quite sure why.

It passes your old tests, but not the new ones I've put in.

  1) Split::Helper ab_test should not store the split when Split generically disabled
     Failure/Error: ab_test('link_color', 'blue', 'red')
       ({}).[]=("link_color", "blue")
           expected: 0 times with any arguments
           received: 1 time with arguments: ("link_color", "blue")
     # ./lib/split/helper.rb:107:in `begin_experiment'
     # ./lib/split/helper.rb:191:in `start_trial'
     # ./lib/split/helper.rb:26:in `ab_test'
     # ./spec/helper_spec.rb:125:in `block (3 levels) in <top (required)>'

  2) Split::Helper ab_test SPLIT_DISABLE query parameter should also force the alternative (uses control)
     Failure/Error: alternative.should eql('blue')

       expected: "blue"
            got: "red"

       (compared using eql?)
     # ./spec/helper_spec.rb:113:in `block (3 levels) in <top (required)>'

@andrew andrew added the Feature label May 6, 2014
@andrew
Copy link
Member

andrew commented May 20, 2014

@brandonparsons Did you have any luck with getting the tests passing?

@brandonparsons
Copy link
Contributor Author

hmmm unfortunately not. I was hoping I could pull that off without having
to go through the entire library to understand what you were doing, but I'm
not 100% sure that is possible :)

On Tue, May 20, 2014 at 4:57 AM, Andrew Nesbitt notifications@github.comwrote:

@brandonparsons https://github.com/brandonparsons Did you have any luck
with getting the tests passing?


Reply to this email directly or view it on GitHubhttps://github.com//pull/246#issuecomment-43611478
.

@andrew
Copy link
Member

andrew commented Aug 4, 2014

Merged in #263

@andrew andrew closed this Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants