#256 avoiding call to params in EncapsulatedHelper #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
cc @jonashuckestein as this basically reverts his last commit: 67601fc |
Contributor
|
Alas, a memory stirs ... This is out of context for me, but IIRC the point of the commit was to allow the overriding of tests using url params. Looks like this wouldn't be possible anymore. In any case, your change is fine with me, because I'm no longer on the project and I'm not sure if split is still used in that way. Thanks for the heads up! cc @tomblomfield if this matters to you, you may want to try to find a better solution :) |
andrew
added a commit
that referenced
this pull request
Sep 25, 2014
#256 avoiding call to params in EncapsulatedHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #256