Experiments with single-quotes break "Use This" functionality #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-quotes don't cause misnamed experiments to be deemed the winner
Member
|
Ah nice catch @ecaron, thanks! |
andrew
added a commit
that referenced
this pull request
Sep 16, 2014
Experiments with single-quotes break "Use This" functionality
Contributor
Author
|
Will there be a v0.7.3 bump? |
Member
|
@ecaron yeah I'm just writing up the release notes now, should be available in a few minutes. |
Contributor
Author
|
You're every bit as awesome as your avatar implies. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any experiment name contains a single quote, the lack of escaping in the dashboard causes a misnamed experiment (e.g. "You'll Love It" becomes "You") to be declared the winner, leaving all experiments looking like Losers and associated ab_test getting back a name it wasn't expecting.
(Escape mechanism is taken from http://www.sinatrarb.com/faq.html#escape_html)