Skip to content

Conversation

@qpowell
Copy link

@qpowell qpowell commented Oct 10, 2014

Removing support for old versions as recommended in #270

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to require the engine if Rails is defined, but just remove the version check here.

@andrew
Copy link
Member

andrew commented Oct 10, 2014

Looking good, I left a couple inline comments of small changes to make and then we can merge it.

Don't worry about that failing spec on travis, it's unrelated to the changes you've made.

🤘

@qpowell
Copy link
Author

qpowell commented Oct 10, 2014

Awesome, I'll get those things taken care of today

@qpowell
Copy link
Author

qpowell commented Oct 12, 2014

@andrew Added those last 2 items. Let me know if there's anything else

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling 8277715 on qpowell:remove-old-version-support into 55068c4 on andrew:master.

@andrew
Copy link
Member

andrew commented Oct 12, 2014

@qpowell that looks great, thanks.

One thing you might want to do is make sure your git and github account is correctly set up so the commits are correctly linked to your account: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user

andrew added a commit that referenced this pull request Oct 12, 2014
Remove support for Ruby 1.8.7 and Rails 2.3
@andrew andrew merged commit 2aa530c into splitrb:master Oct 12, 2014
@qpowell
Copy link
Author

qpowell commented Oct 12, 2014

@andrew Thanks. Didn't realize my work email hadn't been linked to my account yet.

@andrew
Copy link
Member

andrew commented Oct 12, 2014

@qpowell I've released this as v1.0.0: https://github.com/andrew/split/releases/tag/v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants