-
-
Notifications
You must be signed in to change notification settings - Fork 369
Remove support for Ruby 1.8.7 and Rails 2.3 #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want to require the engine if Rails is defined, but just remove the version check here.
|
Looking good, I left a couple inline comments of small changes to make and then we can merge it. Don't worry about that failing spec on travis, it's unrelated to the changes you've made. 🤘 |
|
Awesome, I'll get those things taken care of today |
|
@andrew Added those last 2 items. Let me know if there's anything else |
|
@qpowell that looks great, thanks. One thing you might want to do is make sure your git and github account is correctly set up so the commits are correctly linked to your account: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user |
Remove support for Ruby 1.8.7 and Rails 2.3
|
@andrew Thanks. Didn't realize my work email hadn't been linked to my account yet. |
|
@qpowell I've released this as v1.0.0: https://github.com/andrew/split/releases/tag/v1.0.0 |
Removing support for old versions as recommended in #270