If the DNS resolution fails for your redis server, ruby will throw a SocketError, which is currently not rescued by the ab_test helper #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protip: Don't delete a redis instance your production server is currently using.
If wanted, I can add both:
getaddrinfo: Name or service not knownhelper_spec.rbfile does have tests for redis being unavailable, but it currently only tests the raise ofErrno::ECONNREFUSEDand notRedis::CannotConnectError.