Skip to content

Conversation

@fusion2004
Copy link
Contributor

Protip: Don't delete a redis instance your production server is currently using.

If wanted, I can add both:

  1. Checking for the specific error message DNS resolution failures produce: getaddrinfo: Name or service not known
  2. A test for raising this specific error, though I'm not exactly where it should go. The helper_spec.rb file does have tests for redis being unavailable, but it currently only tests the raise of Errno::ECONNREFUSED and not Redis::CannotConnectError.

…SocketError, which is currently uncaught by the ab_test helper
@andrew
Copy link
Member

andrew commented Apr 15, 2015

Thanks @fusion2004!

andrew added a commit that referenced this pull request Apr 15, 2015
If the DNS resolution fails for your redis server, ruby will throw a SocketError, which is currently not rescued by the ab_test helper
@andrew andrew merged commit 31c59ee into splitrb:master Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants