Skip to content

Implement filtering dashboard by active/complete experiments #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2016
Merged

Implement filtering dashboard by active/complete experiments #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/split/dashboard/public/dashboard-filtering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,29 @@ $(function() {
$('#clear-filter').on('click', function() {
$('#filter').val('');
$('div.experiment').show();
$('#toggle-active').val('Hide active');
$('#toggle-completed').val('Hide completed');
});

$('#toggle-active').on('click', function() {
$button = $(this);
if ($button.val() == 'Hide active') {
$button.val('Show active');
} else {
$button.val('Hide active');
}

$('div.experiment[data-complete="false"]').toggle();
});

$('#toggle-completed').on('click', function() {
$button = $(this);
if ($button.val() == 'Hide completed') {
$button.val('Show completed');
} else {
$button.val('Hide completed');
}

$('div.experiment[data-complete="true"]').toggle();
});
});
2 changes: 1 addition & 1 deletion lib/split/dashboard/views/_experiment.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<% experiment.calc_winning_alternatives %>

<div class="<%= experiment_class %>" data-name="<%= experiment.name %>">
<div class="<%= experiment_class %>" data-name="<%= experiment.name %>" data-complete="<%= experiment.has_winner? %>">
<div class="experiment-header">
<h2>
Experiment: <%= experiment.name %>
Expand Down
4 changes: 3 additions & 1 deletion lib/split/dashboard/views/index.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<p class="intro">The list below contains all the registered experiments along with the number of test participants, completed and conversion rate currently in the system.</p>

<input type="text" placeholder="Begin typing to filter" id="filter" />
<input type="button" id="clear-filter" value="Clear filter" />
<input type="button" id="toggle-completed" value="Hide completed" />
<input type="button" id="toggle-active" value="Hide active" />
<input type="button" id="clear-filter" value="Clear filters" />

<% @experiments.each do |experiment| %>
<% if experiment.goals.empty? %>
Expand Down