Do not storage alternative in cookie if experiment has a winner #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Trial#choose!method always persist the alternative for an experiment regardless if it has a winner or no. The only difference for them is that they don'tincrement_participationwhen the experiment has a winner.The reason why we sometimes see closed experiments and sometimes we don't in the cookies is because when
allow_multiple_experimentswas introduced as a new feature in Split that required tocleanup_old_experimentsbefore a new enrolment a1bc236. This happens at the beginning of the enrolment, that means that if the last experiment enrolled was closed it will be persisted in the cookie, but if not it will be cleaned for any further enrolment on another experiment.