Skip to content

Add sealed time to bottle platform data - #29

Merged
laura-splits merged 1 commit into
mainfrom
laura/bottle-sealed-time
Aug 5, 2026
Merged

Add sealed time to bottle platform data#29
laura-splits merged 1 commit into
mainfrom
laura/bottle-sealed-time

Conversation

@laura-splits

Copy link
Copy Markdown
Contributor

Add sealed_at field in the bottle platform data for display.

@laura-splits
laura-splits requested a review from marctrem August 5, 2026 14:17
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 5, 2026, 3:06 PM

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fefc20de-6588-4918-87bf-294929acd98c

📥 Commits

Reviewing files that changed from the base of the PR and between 12bbbdf and d03e691.

⛔ Files ignored due to path filters (2)
  • gen/es/proto/splitsecure/bottle/v1/platform_data_pb.ts is excluded by !**/gen/**, !gen/**
  • gen/go/proto/splitsecure/bottle/v1/platform_data.pb.go is excluded by !**/*.pb.go, !**/gen/**, !gen/**
📒 Files selected for processing (1)
  • proto/splitsecure/bottle/v1/platform_data.proto
📜 Recent review details
🔇 Additional comments (1)
proto/splitsecure/bottle/v1/platform_data.proto (1)

4-4: LGTM!

Also applies to: 41-44


Walkthrough

PlatformData now records the enclave-reported bottle sealing time with a protobuf timestamp, separate from audit observation timestamps.

Changes

PlatformData timestamp

Layer / File(s) Summary
Add sealed_at timestamp
proto/splitsecure/bottle/v1/platform_data.proto
Imports google/protobuf/timestamp.proto and adds the documented enclave-reported sealed_at timestamp field to PlatformData.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: marctrem

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of the sealed time to bottle platform data.
Description check ✅ Passed The description directly explains that the sealed_at field was added to bottle platform data for display.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@proto/splitsecure/bottle/v1/platform_data.proto`:
- Around line 42-44: Update the documentation comment for sealed_at to refer to
the repository-defined AuditObservationReceipt and replace “audit observation
staple” with “audit observation receipt,” preserving the rest of the guidance.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2dbb7539-0c12-493a-8449-4318b6d921aa

📥 Commits

Reviewing files that changed from the base of the PR and between 8d7f408 and b8f05e5.

📒 Files selected for processing (1)
  • proto/splitsecure/bottle/v1/platform_data.proto
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Check Generated Code
🔇 Additional comments (1)
proto/splitsecure/bottle/v1/platform_data.proto (1)

4-4: LGTM!

Comment thread proto/splitsecure/bottle/v1/platform_data.proto Outdated
@laura-splits
laura-splits force-pushed the laura/bottle-sealed-time branch 2 times, most recently from 404b5e6 to e469cf8 Compare August 5, 2026 14:45
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@laura-splits
laura-splits force-pushed the laura/bottle-sealed-time branch from e469cf8 to d03e691 Compare August 5, 2026 15:06
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@laura-splits
laura-splits merged commit b143673 into main Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants