Fix original_file_name field typo in whoami and arp discovery detections - #4245
Merged
nasbench merged 2 commits intoAug 31, 2026
Merged
Conversation
munzzyy
requested review from
P4T12ICK,
RavenTait,
ljstella,
nasbench,
onurmerdogan,
patel-bhavin,
pyth0n1c,
rosplk and
tccontre
as code owners
August 30, 2026 18:24
nasbench
approved these changes
Aug 31, 2026
nasbench
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the quick fix
nasbench
enabled auto-merge (squash)
August 31, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Both searches OR two conditions to catch a renamed LOLBin:
process_name, or the PE's original file name field (survives a rename). The second condition referencesProcesses.process_original_file_name. That field does not exist in the CIM Endpoint.Processes model. The correct field isProcesses.original_file_name, already used correctly a few lines down in each detection's own BY clause.A field with no indexed values contributes nothing to a tstats OR. Both detections quietly collapse to a plain
process_name="whoami.exe"orprocess_name="arp.exe"check. Rename the binary and both miss it. Catching that exact case is the whole point of checking original_file_name.Fixed files:
detections/endpoint/system_user_discovery_with_whoami.ymldetections/endpoint/network_connection_discovery_with_arp.ymlChecked against the CIM 5.3 Endpoint docs,
original_file_nameis the only valid field. Bumped version and modification_date on both.Ran
contentctl-ng buildlocally against develop with these files changed. All 2157 detections parsed clean, corrected SPL renders right in savedsearches.conf. No Splunk instance here to replay the attack_data tests, so the True Positive test is unconfirmed end to end. Happy to add anything else the checklist needs, thanks.Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclature - N/A, no detection added or renamedcontentctl-ng buildlocally instead, see note above