Skip to content

Fix original_file_name field typo in whoami and arp discovery detections - #4245

Merged
nasbench merged 2 commits into
splunk:developfrom
munzzyy:fix/original-file-name-field-typo
Aug 31, 2026
Merged

Fix original_file_name field typo in whoami and arp discovery detections#4245
nasbench merged 2 commits into
splunk:developfrom
munzzyy:fix/original-file-name-field-typo

Conversation

@munzzyy

@munzzyy munzzyy commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Details

Both searches OR two conditions to catch a renamed LOLBin: process_name, or the PE's original file name field (survives a rename). The second condition references Processes.process_original_file_name. That field does not exist in the CIM Endpoint.Processes model. The correct field is Processes.original_file_name, already used correctly a few lines down in each detection's own BY clause.

A field with no indexed values contributes nothing to a tstats OR. Both detections quietly collapse to a plain process_name="whoami.exe" or process_name="arp.exe" check. Rename the binary and both miss it. Catching that exact case is the whole point of checking original_file_name.

Fixed files:

  • detections/endpoint/system_user_discovery_with_whoami.yml
  • detections/endpoint/network_connection_discovery_with_arp.yml

Checked against the CIM 5.3 Endpoint docs, original_file_name is the only valid field. Bumped version and modification_date on both.

Ran contentctl-ng build locally against develop with these files changed. All 2157 detections parsed clean, corrected SPL renders right in savedsearches.conf. No Splunk instance here to replay the attack_data tests, so the True Positive test is unconfirmed end to end. Happy to add anything else the checklist needs, thanks.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature - N/A, no detection added or renamed
  • CI/CD jobs passed - ran contentctl-ng build locally instead, see note above
  • Validated SPL logic.
  • Validated tags, description, and how to implement. - N/A, unchanged
  • Verified references match analytic. - N/A, unchanged
  • Confirm updates to lookups are handled properly. - N/A, no lookups touched

@nasbench nasbench left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix

@nasbench nasbench added this to the v6.6.0 milestone Aug 31, 2026
@nasbench
nasbench enabled auto-merge (squash) August 31, 2026 09:16
@nasbench
nasbench merged commit 6e80f29 into splunk:develop Aug 31, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants