Skip to content

fix(deps): bump click to 8.4.2 for VULN-88801 - #124

Merged
shuningc merged 1 commit into
mainfrom
VULN-88801-click-upgrade
Jul 28, 2026
Merged

fix(deps): bump click to 8.4.2 for VULN-88801#124
shuningc merged 1 commit into
mainfrom
VULN-88801-click-upgrade

Conversation

@shuningc

Copy link
Copy Markdown
Contributor

Summary

  • Remediate VULN-88801 (command injection in click.edit(); fixed in 8.3.3, ≤8.3.2 vulnerable).
  • poetry.lock bumps click 8.1.8 → 8.4.2 (transitive; no pyproject.toml change, content-hash unchanged).
  • Example pin elastic-chatbot-rag-app/requirements.txtclick==8.3.3; langgraph-fsi-agent/before/poetry.lock → 8.4.2.

Notes

  • 8.4.2 satisfies all dependents: crewai >=8.1.7, litellm >=8.0.0,<9.0, httpx ==8.*, uvicorn >=7.0.
  • The langgraph example lock update also reconciled a ruff entry declared in its pyproject but missing from the stale lock.

Test plan

  • poetry check
  • poetry run pytest tests/ (1988 passed, 10 skipped)

Jira

VULN-88801

Remediate the click.edit() command injection (fixed in 8.3.3; <=8.3.2 vulnerable)
by pinning click in poetry.lock without changing project structure (click stays
transitive). Main lock resolves click 8.4.2; example pin bumped to 8.3.3 and the
langgraph example lock updated to 8.4.2 (also reconciles its stale ruff entry).

Co-authored-by: Cursor <cursoragent@cursor.com>
@shuningc
shuningc requested review from fercor-cisco and keith-decker and removed request for keith-decker July 23, 2026 00:12
@etserend

Copy link
Copy Markdown
Contributor

Code Review — AI-Assisted Feedback

Reviewed by Claude Code (Claude Opus), automated review to assist human reviewers.

Verdict: Approve with comments

Minimal, well-scoped CVE fix. One optional consistency nit noted below.


P3 — Inconsistent click version pin across examples (Claude Code)

File/Section: examples/rag/elastic-chatbot-rag-app/requirements.txt
Issue: This example pins click==8.3.3 while the main poetry.lock and examples/agent/langgraph-fsi-agent/before/poetry.lock both resolve to 8.4.2. Both versions are past the CVE fix boundary (8.3.3+), so this is not a security concern — purely a consistency nit.
Recommended fix: Optionally bump the example pin to click==8.4.2 to eliminate version drift across examples.


Reviewer Model Key Contribution
Claude Code Claude Opus Version drift between example pin and lockfile

@etserend
etserend self-requested a review July 28, 2026 14:35
@shuningc
shuningc merged commit 5a6c58f into main Jul 28, 2026
13 checks passed
@shuningc
shuningc deleted the VULN-88801-click-upgrade branch July 28, 2026 18:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants