Partially fixes broken py26 support #141#142
Closed
Vye wants to merge 1 commit intosplunk:masterfrom
Vye:fixes-py26-support
Closed
Partially fixes broken py26 support #141#142Vye wants to merge 1 commit intosplunk:masterfrom Vye:fixes-py26-support
Vye wants to merge 1 commit intosplunk:masterfrom
Vye:fixes-py26-support
Conversation
Contributor
|
Thanks for the PR @Vye, can you create another on against the |
Contributor
|
Closed in favor of #143 |
mateusz834
added a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dictionary comprehensions. shutil.make_archive is used as well (added in py27) which will need to be changed. There may be other changes required as well.